Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to check a wave-fc file and check for valid kerchunk indices #5

Merged

Conversation

lawi119
Copy link
Contributor

@lawi119 lawi119 commented Oct 30, 2023

Before you submit a pull request, please fill in the following:

Related Issue(s):
N/A

Description:
Added in an update tests/test_stac.py that checked for valid kerchunk indices and used a wave-fc file for the checks. This file was meant to be a part of the previous PR.

PR checklist:

  • [Y] Code is formatted (run scripts/format).
  • [Y] Code lints properly (run scripts/lint).
  • [Y] Tests pass (run scripts/test).
  • [Y] Documentation has been updated to reflect changes, if applicable.
  • [Y] Changes are added to the CHANGELOG.

tests/test_stac.py Outdated Show resolved Hide resolved
@TomAugspurger
Copy link
Member

A couple test failures:

>           assert item.properties["kerchunk_indices"] == kerchunk_indices

I think we changed this to kerchunk:indices.

E               FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/ecmwf-forecast/ecmwf-forecast/ecmwf/20231019/00z/0p4-beta/wave/20231019000000-0h-wave-fc.grib2'

I think now we need the files to be present, since we actually read them (previously we just used the path structure).

I'd prefer not to have large data files in the source repo. So we'll want to fetch these (probably from Azure Blob Storage) when we run the test. We can cache it locally so that we don't need to download it every time. Can you take care of that?

@lawi119
Copy link
Contributor Author

lawi119 commented Oct 31, 2023

Done.

@TomAugspurger
Copy link
Member

Looks like one test failure, from the updated base64 logic:

E             -           'step/0': '\x00\x00\x00\x00\x00\x00\x00\x00',
E             +           'step/0': 'base64:AAAAAAAAAAA=',

tests/test_stac.py Outdated Show resolved Hide resolved
tests/test_stac.py Outdated Show resolved Hide resolved
tests/test_stac.py Outdated Show resolved Hide resolved
tests/test_stac.py Outdated Show resolved Hide resolved
@TomAugspurger TomAugspurger merged commit a85596d into stactools-packages:main Nov 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants