Skip to content

Conversation

@francesco-stacks
Copy link

Description

Fourth of 7 PRs that will supersede #6661

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo

@francesco-stacks francesco-stacks self-assigned this Nov 20, 2025
@francesco-stacks francesco-stacks added aac Avoiding Accidental Consensus aac-testing Avoiding Accidental Consensus Testing Specific Task labels Nov 20, 2025
@francesco-stacks francesco-stacks moved this to Status: In Review in Stacks Core Eng Nov 20, 2025
@francesco-stacks francesco-stacks marked this pull request as ready for review November 20, 2025 09:53
@francesco-stacks francesco-stacks requested review from a team as code owners November 20, 2025 09:53
}

/// StaticCheckErrorKind: [`StaticCheckErrorKind::IllegalOrUnknownFunctionApplication`]
/// Caused by:
Copy link
Contributor

@jacinta-stacks jacinta-stacks Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha I know its redundant considering how explicit the static check error kind name is, but it irks my soul that these Caused by's are empty :P (Note: you should not fill them out. Its pointless to do so lol )

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually do have to fill them out, or I'll not be able to sleep properly! I just forgot, thanks for pointing out!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in d7345b4 (alonside resolving merge conflicts)

jacinta-stacks
jacinta-stacks previously approved these changes Nov 21, 2025
Copy link
Contributor

@jacinta-stacks jacinta-stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 74.74747% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.57%. Comparing base (cda6a5e) to head (d7345b4).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...slib/src/chainstate/tests/static_analysis_tests.rs 74.74% 25 Missing ⚠️

❌ Your project check has failed because the head coverage (70.57%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (cda6a5e) and HEAD (d7345b4). Click for more details.

HEAD has 14 uploads less than BASE
Flag BASE (cda6a5e) HEAD (d7345b4)
142 128
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6703      +/-   ##
===========================================
- Coverage    80.03%   70.57%   -9.46%     
===========================================
  Files          577      577              
  Lines       357651   357750      +99     
===========================================
- Hits        286235   252477   -33758     
- Misses       71416   105273   +33857     
Files with missing lines Coverage Δ
...slib/src/chainstate/tests/static_analysis_tests.rs 75.12% <74.74%> (-20.07%) ⬇️

... and 333 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cda6a5e...d7345b4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aac Avoiding Accidental Consensus aac-testing Avoiding Accidental Consensus Testing Specific Task

Projects

Status: Status: In Review

Development

Successfully merging this pull request may close these issues.

3 participants