Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Apply Clippy lints derivable_impls, eq_op, and expect_fun_call #5773

Merged
merged 4 commits into from
Feb 7, 2025
Merged

chore: Apply Clippy lints derivable_impls, eq_op, and expect_fun_call #5773

merged 4 commits into from
Feb 7, 2025

Conversation

jbencin
Copy link
Contributor

@jbencin jbencin commented Jan 30, 2025

Description

Apply the following Clippy lints:

  • derivable_impls: Replace manually implemented Default traits
  • eq_op: Find instances of a == a (indicates copy/paste error)
  • expect_fun_call: Find and replace format strings in expect() calls

@jbencin jbencin added the lint Related to linting/clippy/cargo warns label Jan 30, 2025
@jbencin jbencin requested a review from a team as a code owner January 30, 2025 15:19
@jbencin jbencin requested a review from kantai January 30, 2025 19:43
obycode
obycode approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@obycode obycode added this pull request to the merge queue Feb 7, 2025
Merged via the queue into stacks-network:develop with commit ea79fdc Feb 7, 2025
183 checks passed
@jbencin jbencin deleted the chore/clippy-derivable-impls-eq-op-expect-fun-call branch February 7, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kantai kantai kantai approved these changes

@obycode obycode obycode approved these changes

@jcnelson jcnelson Awaiting requested review from jcnelson

@jferrant jferrant Awaiting requested review from jferrant

Assignees
No one assigned
Labels
lint Related to linting/clippy/cargo warns
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbencin @kantai @obycode