Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Signer Alongside Node #5756

Merged
merged 6 commits into from
Feb 8, 2025
Merged

Conversation

BowTiedDevOps
Copy link
Collaborator

The aim of this PR is to create a signer release every time there is a core release happening, with the tag set as <core_release>.0.

Note: The Actions PR will have to be merged before this can be merged, as it references composite actions that are not existent in the current flow but in the one proposed by that PR.

Example workflows (test failures are unaffected by these changes):

Useful Links:

@BowTiedDevOps BowTiedDevOps added enhancement Iterations on existing features or infrastructure. CI labels Jan 27, 2025
@BowTiedDevOps BowTiedDevOps self-assigned this Jan 27, 2025
@BowTiedDevOps BowTiedDevOps requested a review from a team as a code owner January 27, 2025 23:42
@wileyj
Copy link
Collaborator

wileyj commented Jan 28, 2025

Note that the required checks here will fail until the required actions PR is merged.

@BowTiedDevOps let's also use this PR to fix the alpine images which are currently configured to use glibc (they should be using the musl binaries for the release) https://github.com/BowTiedDevOps/stacks-core/blob/develop/.github/actions/dockerfiles/Dockerfile.alpine-binary#L13-L16

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@wileyj wileyj requested a review from a team January 31, 2025 22:03
@wileyj
Copy link
Collaborator

wileyj commented Jan 31, 2025

will double-check the binaries/images in the fork, otherwise it looks good to me (and should resolve the issue from the previous PR)

@BowTiedDevOps
Copy link
Collaborator Author

BowTiedDevOps commented Feb 3, 2025

I've updated the comments to further explain the outputs of the check-release job and the conditionals used within the file. I've also changed the conditionals to look like this:

+ needs.check-release.outputs.is_node_release == 'true' ||
  needs.check-release.outputs.is_signer_release == 'true'

Even though this is not necessary for the tests to run properly (i.e. is_signer_release will always be true if is_node_release is true), it adds more clarity to what the conditions do.

Copy link
Member

@CharlieC3 CharlieC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: LGTM! Thanks for the added commentary!

@aldur aldur added this to the 3.1.0.0.6 milestone Feb 4, 2025
@wileyj
Copy link
Collaborator

wileyj commented Feb 5, 2025

double checked the binaries/images after discovering we've had broken alpine docker images for a while. latest changes resolve problem

@wileyj wileyj requested a review from a team February 5, 2025 19:05
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good.

@fabergat
Copy link

fabergat commented Feb 7, 2025

LGTM.

@obycode
Copy link
Contributor

obycode commented Feb 7, 2025

Looks like there is an issue:

Download action repository 'stacks-network/actions@main' (SHA:4934e89e192d94d285a6fe786011bdd3d9879e32)
Error: Can't find 'action.yml', 'action.yaml' or 'Dockerfile' for action 'stacks-network/actions/stacks-core/release/check-release@main'.

EDIT: This is because of the change needed in the actions repo.

@wileyj wileyj added this pull request to the merge queue Feb 8, 2025
Merged via the queue into stacks-network:develop with commit 851ada6 Feb 8, 2025
182 checks passed
@wileyj wileyj deleted the develop branch February 8, 2025 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI enhancement Iterations on existing features or infrastructure.
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

7 participants