-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release Signer Alongside Node #5756
Conversation
Note that the required checks here will fail until the required actions PR is merged. @BowTiedDevOps let's also use this PR to fix the alpine images which are currently configured to use glibc (they should be using the musl binaries for the release) https://github.com/BowTiedDevOps/stacks-core/blob/develop/.github/actions/dockerfiles/Dockerfile.alpine-binary#L13-L16 |
will double-check the binaries/images in the fork, otherwise it looks good to me (and should resolve the issue from the previous PR) |
I've updated the comments to further explain the outputs of the + needs.check-release.outputs.is_node_release == 'true' ||
needs.check-release.outputs.is_signer_release == 'true' Even though this is not necessary for the tests to run properly (i.e. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the added commentary!
double checked the binaries/images after discovering we've had broken alpine docker images for a while. latest changes resolve problem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good.
LGTM. |
EDIT: This is because of the change needed in the actions repo. |
The aim of this PR is to create a signer release every time there is a core release happening, with the tag set as
<core_release>.0
.Note: The Actions PR will have to be merged before this can be merged, as it references composite actions that are not existent in the current flow but in the one proposed by that PR.
Example workflows (test failures are unaffected by these changes):
5.0.0.0.0
andsigner-5.0.0.0.0.0
releases): https://github.com/BowTiedDevOps/stacks-core/actions/runs/12953974660signer-5.0.0.0.0.1
release): https://github.com/BowTiedDevOps/stacks-core/actions/runs/12957741282develop
branch CI run: https://github.com/BowTiedDevOps/stacks-core/actions/runs/12960606782Useful Links: