Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix int_plus_one warnings #5626

Merged
merged 8 commits into from
Feb 8, 2025
Merged

Conversation

jferrant
Copy link
Collaborator

No description provided.

Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant jferrant requested a review from a team as a code owner December 31, 2024 18:13
jbencin
jbencin previously approved these changes Dec 31, 2024
obycode
obycode previously approved these changes Jan 2, 2025
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

jcnelson
jcnelson previously approved these changes Jan 2, 2025
@jferrant jferrant dismissed stale reviews from jcnelson, obycode, and jbencin via 680010d January 2, 2025 23:05
obycode
obycode previously approved these changes Jan 3, 2025
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

… into fix/clippy-ci-stacks-lib-int-plus-one
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

jbencin
jbencin previously approved these changes Jan 3, 2025
… into fix/clippy-ci-stacks-lib-int-plus-one
@jferrant jferrant dismissed stale reviews from jbencin and obycode via a83067d January 4, 2025 01:38
… into fix/clippy-ci-stacks-lib-int-plus-one
@jbencin jbencin added the lint Related to linting/clippy/cargo warns label Jan 23, 2025
@obycode obycode enabled auto-merge January 23, 2025 19:15
@jferrant
Copy link
Collaborator Author

@jcnelson are you satisfied with the explanation? Don't want to dismiss your review without confirmation.

@obycode obycode added this pull request to the merge queue Feb 8, 2025
Merged via the queue into develop with commit 4dadde0 Feb 8, 2025
164 checks passed
@obycode obycode deleted the fix/clippy-ci-stacks-lib-int-plus-one branch February 8, 2025 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lint Related to linting/clippy/cargo warns
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants