feat: add build-time git info #5579
Open
+75
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jferrant
previously approved these changes
Dec 17, 2024
obycode
reviewed
Dec 17, 2024
obycode
reviewed
Dec 17, 2024
jbencin
reviewed
Dec 18, 2024
jbencin
reviewed
Dec 18, 2024
jbencin
reviewed
Dec 18, 2024
jbencin
reviewed
Dec 18, 2024
obycode
previously approved these changes
Jan 24, 2025
wileyj
dismissed stale reviews from obycode and jferrant
The base branch was changed.
kantai
approved these changes
Feb 7, 2025
|
oh goody. new flaky tests |
|
I updated to the latest develop to see if anything changed with those tests, but then I realized @kantai just did that a few hours ago, so I don't think anything has changed with regards to flaky tests since then. |
|
I think we can be pretty sure that this flakiness is not caused by these changes. I think we can go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #5399, I noticed that we have a root-level
build.rsfile that gets git info, but we weren't using that.Because 5399 introduces a build-time constants file, I figured I'd open this PR to also include Git info without needing to specify
GIT_COMMITandGIT_BRANCHENV variables. This way, you always get the "full version string" regardless of how you runcargo build. This, along with 5399, means we can be rid of the unhelpful0.0.1version strings when people do custom builds.I'm relatively ambivalent about this change - let me know what you think.