Skip to content

Commit

Permalink
CRC: fix typo and remove TODO comment about unused var
Browse files Browse the repository at this point in the history
Signed-off-by: Jacinta Ferrant <[email protected]>
  • Loading branch information
jferrant committed Feb 7, 2025
1 parent f4bd71c commit bd12b6e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ and this project adheres to the versioning scheme outlined in the [README.md](RE

- Logging improvements:
- P2P logs now includes a reason for dropping a peer or neighbor
- Imrpovements to how a PeerAddress is logged (human readable format vs hex)
- Improvements to how a PeerAddress is logged (human readable format vs hex)

### Fixed

Expand Down
10 changes: 3 additions & 7 deletions stackslib/src/net/inv/epoch2x.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2302,29 +2302,25 @@ impl PeerNetwork {
stats.done
);
if !stats.done {
// TODO: the result of this match doesn't seem to be used? is that intentional?
match network.inv_sync_run(&mut new_pins, sortdb, nk, stats, inv_state.request_timeout, ibd) {
Ok(d) => d,
Ok(_) => {}
Err(net_error::StaleView) => {
// stop work on this state machine -- it needs to be restarted.
// we'll need to keep scanning.
debug!("{:?}: stale PoX view; will rescan", &network.local_peer);
stats.done = true;
inv_state.hint_learned_data = true;
inv_state.hint_learned_data_height = u64::MAX;
true
}
Err(net_error::PeerNotConnected) | Err(net_error::SendError(..)) => {
stats.status = NodeStatus::Dead;
true
}
Err(e) => {
debug!(
"{:?}: remote neighbor inv_sync_run finished with error {:?}",
&network.local_peer, &e
"{:?}: remote neighbor inv_sync_run finished with error {e:?}",
&network.local_peer
);
stats.status = NodeStatus::Broken;
true
}
};

Expand Down

0 comments on commit bd12b6e

Please sign in to comment.