feat: add gettxout and getmempoolentry endpoints + tests
#858
+424
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nding-the-signers-utxo
…nding-the-signers-utxo
1 task
djordon
reviewed
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to (prerequisite) #759
Changes
Adds implementation and tests for Bitcoin-core's
gettxoutandgetmempoolentryRPC endpoints.While
gettxoutproved to be unreliable when trying to calculate fees for an unknown potential mixture of confirmed/unconfirmed transactions, if you know whether or not its confirmed or not then it works fine (see tests). So it's not going to be used in #759 but I decided to leave it in as it can be useful.Reverts bitcoin core to 25.1 in docker compose files.
Testing Information
Added a number of tests testing both methods.
Checklist: