Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: DKG verification pre-key-rotation #1301

Merged
merged 98 commits into from
Feb 7, 2025
Merged

feat: DKG verification pre-key-rotation #1301

merged 98 commits into from
Feb 7, 2025

Conversation

cylewitruk
Copy link
Member

@cylewitruk cylewitruk commented Feb 4, 2025 •
edited by djordon
Loading

Description

Closes: #1300 (Alternative 3), closes #1313.

Followup to PR's #1287 and #1285 (both are now merged).

I'm still actively working on this but feel free to comment

Changes

Testing Information

Checklist:

  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

xoloki and others added 30 commits January 23, 2025 21:10
@xoloki
update for wsts 11
9306dfa
@xoloki
use wsts 11.0.0 from crates
c986d2a
@xoloki
fix rebase
25ac3be
@xoloki
use wsts-12.0.0 from crates
cf13953
@xoloki
add FrostCoordinator to wsts_state_machine so we can run signing roun…
6cb670a 
…ds where all signers must participate
@cylewitruk
wip
31726ee
@cylewitruk
Merge branch 'feat/frost-coordinator' into feat/require-all-signature…
63731bb 
…s-for-rotate-keys
@cylewitruk
run a dkg signing before deploying contracts
105d9a7
@cylewitruk
new wsts commit
4d406ee
@cylewitruk
wip
1218eb6
@cylewitruk
Merge branch 'main' into feat/require-all-signatures-for-rotate-keys
4179cd6
@cylewitruk
seems to work
be05f5e
@cylewitruk
working version
43501cb
@cylewitruk
Merge branch 'main' into feat/require-all-signatures-for-rotate-keys
a0ce153
@cylewitruk
remove dead code
a75f5a5
@cylewitruk
minor wsts logging tweaks
2214427
@cylewitruk
Merge branch 'main' into feat/require-all-signatures-for-rotate-keys
1511969
@cylewitruk
rename wstsmessageid variant
25d214a
@cylewitruk
it works, now need to clean up
18b69d2
@cylewitruk
downgrade wsts
7412f87
@cylewitruk
proto backwards compatability fixes
5a16608
@cylewitruk
Merge branch 'main' into feat/require-all-signatures-for-rotate-keys
0e624e6
@cylewitruk
some wsts cleanup/refactor
e867b72
@cylewitruk
think that's it
c742af2
@cylewitruk
add message support for a specific dkg wstsmessageid
347db71
@cylewitruk
add a dkg wstsmessageid variant
df5111f
@cylewitruk
merge changes from the refactor branch
e1173f6
@cylewitruk
use block hash instead of random data
758c6c2
@cylewitruk
fmt
8acccaf
@cylewitruk
remove 100% requirement for stacks signing of rotate keys
00537be
@cylewitruk cylewitruk changed the base branch from feat/require-all-signatures-for-rotate-keys to main February 6, 2025 16:23
@djordon djordon mentioned this pull request Feb 6, 2025
Merged
1 task
cylewitruk and others added 18 commits February 7, 2025 02:38
@cylewitruk
Squashed commit of the following:
480b10a 
commit 2168f58
Author: Cyle Witruk <[email protected]>
Date:   Thu Feb 6 16:08:22 2025 +0100

    feat: consensus on successful DKG prior to rotate-keys submission (#1285)

    * update for wsts 11

    * use wsts 11.0.0 from crates

    * fix rebase

    * use wsts-12.0.0 from crates

    * add FrostCoordinator to wsts_state_machine so we can run signing rounds where all signers must participate

    * wip

    * run a dkg signing before deploying contracts

    * new wsts commit

    * wip

    * seems to work

    * working version

    * remove dead code

    * minor wsts logging tweaks

    * rename wstsmessageid variant

    * it works, now need to clean up

    * downgrade wsts

    * proto backwards compatability fixes

    * some wsts cleanup/refactor

    * think that's it

    * add message support for a specific dkg wstsmessageid

    * add a dkg wstsmessageid variant

    * use block hash instead of random data

    * fmt

    * remove 100% requirement for stacks signing of rotate keys

    * bump p256k1 to 7.2.2

    * fix merge artifacts

    * tracing fields

    * storage mut

    * lovely cascading changes

    * remove wstsmessage.txid infavor of id

    * remove save and prefer trait default impls

    * remove unused trait methods

    * logging stuff

    * rename message ids

    * use tracing constants

    * remove stale comment

    * remove box from some types

    * missed dkg_begin_pause

    * leftover dbg!()

    * refactor some validation

    * various pr comments

    * mut thing

    * remove unneeded allow(deprecated)

    * confused merge tool

    ---------

    Co-authored-by: Joey Yandle <[email protected]>
@cylewitruk
Merge branch 'main' into feat/mock-signing
b88100b
@djordon @matteojug
Change the DKG shares status type.
7878be8 
Lots of small follow-up modifications
@djordon @matteojug
Update the migration query
daf4946
@djordon @matteojug
Fix up remaining queries
83b96b0
@djordon @matteojug
Oops forgot this one
ee46b3e
@djordon @matteojug
Forgot this rename
aea867b
@djordon @matteojug
Rename the new status field to
27a3bfa 
match the new column
@djordon @matteojug
Fix up the tests and add a new one
5b7cc5d
@djordon @matteojug
Change the return value of some of the
d290aa8 
queries and simplify the validation check. Also add a test.
@djordon @matteojug
Change it back
0ce46d3
@djordon @matteojug
Update the tests
3c837d8
@djordon @matteojug
Clean up the comments in the shares enum
76f6754
@djordon @matteojug
rename the rotate keys error variant
e487615
@djordon @matteojug
Use a better error variant when extracting
4ad9835 
the started_at from the state machine Id
@djordon @matteojug
Remove some of our unused error variants
21cd44b
@djordon @matteojug
Match the behavior in the in memory store
102a3d5 
with the postgres implementation
@djordon @matteojug
We do not need these errors anymore either
45c8299
@cylewitruk cylewitruk marked this pull request as ready for review February 7, 2025 09:13
matteojug
matteojug approved these changes Feb 7, 2025
View reviewed changes
signer/src/bitcoin/utxo.rs Outdated Show resolved Hide resolved
signer/src/error.rs Outdated Show resolved Hide resolved
signer/src/error.rs Outdated Show resolved Hide resolved
signer/tests/integration/transaction_signer.rs Outdated Show resolved Hide resolved
signer/tests/integration/postgres.rs Outdated Show resolved Hide resolved
signer/src/transaction_signer.rs Outdated Show resolved Hide resolved
signer/src/transaction_signer.rs Outdated Show resolved Hide resolved
signer/src/transaction_signer.rs Outdated Show resolved Hide resolved
aldur
aldur reviewed Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@aldur aldur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all nits, feel free to ignore.

Basically, I have read this, it makes sense, but I'll it to the experts.

signer/src/bitcoin/utxo.rs Show resolved Hide resolved
signer/src/bitcoin/utxo.rs Show resolved Hide resolved
signer/src/storage/in_memory.rs Show resolved Hide resolved
signer/src/storage/mod.rs Show resolved Hide resolved
signer/src/storage/postgres.rs Show resolved Hide resolved
@cylewitruk cylewitruk mentioned this pull request Feb 7, 2025
Merged
4 tasks
djordon
djordon approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@djordon djordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@cylewitruk cylewitruk merged commit dc241cf into main Feb 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldur aldur aldur left review comments

@Jiloc Jiloc Jiloc left review comments

@matteojug matteojug matteojug approved these changes

@xoloki xoloki xoloki approved these changes

@djordon djordon djordon approved these changes

Assignees

@cylewitruk cylewitruk

Labels
breaking-protocol Breaking protocol changes key rotation The functionality to rotate a private key for a signer in sBTC-v1. sbtc signer binary The sBTC Bootstrap Signer. signer coordination The actions executed by the signer coordinator.
Projects
sBTC
Status: Done
Milestone
sBTC: Deposits
6 participants
@cylewitruk @xoloki @aldur @Jiloc @matteojug @djordon