This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
refactor: Split serialization from Codec
into separate modules
#414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR proposes to fragment the serialization (
Codec
) implementation for different primitives from codec.rs into separate modules, i.e.:amount
,recoverable_signature
, etc., rename some of the interfaces, and document the code more thoroughly.Background
While implementing the
Codec
trait's unit tests, I noted that the code could benefit from a bit more modularity in favor of readability and making unit tests more focused.Proposed structure
Related PRs
Codec
trait unit tests #413Testing
Run tests normally via
cargo make test
.Risks
None.
How were these changes tested?
The tests included produce the same results as the ones in the existing
Codec
trait implementations, ensuring they work the same.What future testing should occur?
Checklist: