Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Increase stacks client coverage #347

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

CAGS295
Copy link
Contributor

@CAGS295 CAGS295 commented Nov 1, 2023

Summary of Changes

Refactored error handling and added tests.

Testing

Risks

I touched on a few methods without tests. It could have changed the behavior slightly. I checked that none of the callers relied on the old logic, but I could have missed something.

How were these changes tested?

Static analysis and added unit tests.

What future testing should occur?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@CAGS295 CAGS295 force-pushed the dev/cags295/stacks-client branch from 03d9bdb to 76bcb4c Compare November 2, 2023 05:29
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 118 lines in your changes are missing coverage. Please review.

Comparison is base (6470223) 43.44% compared to head (76bcb4c) 47.85%.
Report is 4 commits behind head on main.

❗ Current head 76bcb4c differs from pull request most recent head 41990f1. Consider uploading reports for the commit 41990f1 to get more accurate results

Files Patch % Lines
romeo/src/stacks_client.rs 68.45% 94 Missing ⚠️
romeo/src/system.rs 0.00% 24 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
+ Coverage   43.44%   47.85%   +4.41%     
==========================================
  Files          45       45              
  Lines        5467     5567     +100     
  Branches       47       47              
==========================================
+ Hits         2375     2664     +289     
+ Misses       3091     2902     -189     
  Partials        1        1              
Flag Coverage Δ
unittests 76.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CAGS295 CAGS295 self-assigned this Nov 9, 2023
@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants