This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
Integration ci #303
Draft
Integration ci #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAGS295
force-pushed
the
dev/cags295/integration-CI
branch
from
4c96705 to
aca6b7b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
==========================================
+ Coverage 41.49% 43.09% +1.60%
==========================================
Files 40 45 +5
Lines 5111 5362 +251
Branches 0 47 +47
==========================================
+ Hits 2121 2311 +190
- Misses 2990 3050 +60
- Partials 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CAGS295
force-pushed
the
dev/cags295/integration-CI
branch
from
aca6b7b to
2cd98d7
Compare
|
What's going on with this PR? |
@AshtonStephens I added a brief description. |
|
blocked by #350 |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Follow up PR #215 to add a CI job running integration tests—blocked atm and not actively working on it.
I would appreciate feedback on #307 and #215 first.
Devenv's javascript services are too big and are making 'devenv' CI fail. I can't fix it myself right now without digging deeper. I've thought about options: merging javascript containers, increasing runner's resources, having a dedicated devenv profile to skip building unnecessary services, and last but not least, minimizing image size by having a 'release build' for javascript-based services (My first attempt failed).
This PR exports docker image artifacts from the 'devenv build' job. Blocked by 1.
Split devenv into different node profiles. #307 may help with 1. With devenv profiles, I can have a profile with the minimal services needed for testing.
Testing
Risks
How were these changes tested?
What future testing should occur?
Checklist: