Skip to content

ROX-24313: Minimal fix for the failing network graph test #15237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vikin91
Copy link
Contributor

@vikin91 vikin91 commented May 8, 2025

Description

This is the minimal version of #15156

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

  • CI gke-qa-e2e-tests must pass.

@vikin91 vikin91 requested a review from janisz as a code owner May 8, 2025 13:11
@vikin91 vikin91 added the ci-all-qa-tests Tells CI to run all API tests (not just BAT). label May 8, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vikin91 - I've reviewed your changes - here's some feedback:

  • Increasing the maximum retry attempts five-fold (e.g., from 4 to 20) for network graph assertions may significantly extend test duration in some cases.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rhacs-bot
Copy link
Contributor

Images are ready for the commit at 1f7c020.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-655-g1f7c020343.

Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.11%. Comparing base (10088e1) to head (df24b55).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15237      +/-   ##
==========================================
- Coverage   49.11%   49.11%   -0.01%     
==========================================
  Files        2558     2558              
  Lines      187940   187933       -7     
==========================================
- Hits        92308    92298      -10     
- Misses      88351    88354       +3     
  Partials     7281     7281              
Flag Coverage Δ
go-unit-tests 49.11% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vikin91 vikin91 added the auto-retest PRs with this label will be automatically retested if prow checks fails label May 8, 2025
@vikin91
Copy link
Contributor Author

vikin91 commented May 8, 2025

/retest-times 3 gke-qa-e2e-tests

@rhacs-bot
Copy link
Contributor

rhacs-bot commented May 8, 2025

Images are ready for the commit at df24b55.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-656-gdf24b55c01.

@rhacs-bot
Copy link
Contributor

/test gke-qa-e2e-tests

2 similar comments
@rhacs-bot
Copy link
Contributor

/test gke-qa-e2e-tests

@rhacs-bot
Copy link
Contributor

/test gke-qa-e2e-tests

@rhacs-bot
Copy link
Contributor

/retest

3 similar comments
@rhacs-bot
Copy link
Contributor

/retest

@rhacs-bot
Copy link
Contributor

/retest

@rhacs-bot
Copy link
Contributor

/retest

Copy link

openshift-ci bot commented May 9, 2025

@vikin91: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gke-qa-e2e-tests df24b55 link false /test gke-qa-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-retest PRs with this label will be automatically retested if prow checks fails ci-all-qa-tests Tells CI to run all API tests (not just BAT).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants