-
Notifications
You must be signed in to change notification settings - Fork 156
ROX-24313: Minimal fix for the failing network graph test #15237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vikin91 - I've reviewed your changes - here's some feedback:
- Increasing the maximum retry attempts five-fold (e.g., from 4 to 20) for network graph assertions may significantly extend test duration in some cases.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Images are ready for the commit at 1f7c020. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15237 +/- ##
==========================================
- Coverage 49.11% 49.11% -0.01%
==========================================
Files 2558 2558
Lines 187940 187933 -7
==========================================
- Hits 92308 92298 -10
- Misses 88351 88354 +3
Partials 7281 7281
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/retest-times 3 gke-qa-e2e-tests |
Images are ready for the commit at df24b55. To use with deploy scripts, first |
/test gke-qa-e2e-tests |
2 similar comments
/test gke-qa-e2e-tests |
/test gke-qa-e2e-tests |
/retest |
3 similar comments
/retest |
/retest |
/retest |
@vikin91: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
This is the minimal version of #15156
User-facing documentation
Testing and quality
Automated testing
How I validated my change
gke-qa-e2e-tests
must pass.