chore: enable testifylint linter #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #874 +/- ##
==========================================
- Coverage 62.36% 58.89% -3.47%
==========================================
Files 197 199 +2
Lines 4854 5790 +936
==========================================
+ Hits 3027 3410 +383
- Misses 1439 1988 +549
- Partials 388 392 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rhybrillou
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Hello @mmorel-35 ,
Thank you for this contribution.
At the moment, I see code changes that are likely the fixes to linter reports, but don't see changes that would actually activate the linter itself. Could you check if some configuration file or change to a configuration file is missing ?
mmorel-35
force-pushed
the
golangci-lint/testifylint
branch
from
e6274e3 to
e9ea84c
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
golangci-lint/testifylint
branch
from
e9ea84c to
e2cb2af
Compare
|
Hi @rhybrillou , Indeed I missed it, here it comes ;) |
rhybrillou
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables testifylint which is a linter that checks for usage of github.com/stretchr/testify.