Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-25250: Add deprecated_sub claim mapping #1621

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ivan-degtiarenko
Copy link
Contributor

Description

Once RHSSO dynamic clients will return both sub and deprecated_sub, it will allow for seamless transition to the new format.

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@openshift-ci openshift-ci bot added the lgtm label Jan 25, 2024
Base automatically changed from ivan/acs-login-alternative-user-id to main January 25, 2024 18:13
@kovayur kovayur force-pushed the ivan/add-deprecated-sub-claim-mapping branch from 0547912 to 173beb0 Compare July 17, 2024 10:10
@openshift-ci openshift-ci bot removed the lgtm label Jul 17, 2024
Copy link
Contributor

openshift-ci bot commented Jul 17, 2024

New changes are detected. LGTM label has been removed.

Copy link
Contributor

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaus67, ivan-degtiarenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur kovayur force-pushed the ivan/add-deprecated-sub-claim-mapping branch from 173beb0 to ecdd0cc Compare July 17, 2024 10:12
@kovayur kovayur changed the title Add deprecated_sub claim mapping ROX-25250: Add deprecated_sub claim mapping Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants