Skip to content

Conversation

@jerm-dro
Copy link
Contributor

@jerm-dro jerm-dro commented Jan 6, 2026

Summary

Stacked on #3205
Supports #3125

This PR migrates the telemetry config to use the app config's telemetry config.

Changes

  1. Delete the legacy telemetry config field on the spec.
  2. Preserve the existing application of defaults and normalization of config by converting back into the legacy type. This code is more involved to refactor, so I'm leaving it in place until the refactor is complete.
  3. Update docs and examples.

@github-actions github-actions bot added the size/M Medium PR: 300-599 lines changed label Jan 6, 2026
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 24.24242% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.02%. Comparing base (8e8af3b) to head (179cae2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/thv-operator/pkg/vmcpconfig/converter.go 24.24% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3207      +/-   ##
==========================================
- Coverage   57.06%   57.02%   -0.05%     
==========================================
  Files         350      350              
  Lines       34744    34776      +32     
==========================================
+ Hits        19826    19830       +4     
- Misses      13269    13298      +29     
+ Partials     1649     1648       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jerm-dro jerm-dro force-pushed the jerm/2026-01-06-migrate-telemetry branch from e76ab27 to 6f2983e Compare January 6, 2026 21:56
@github-actions github-actions bot added size/M Medium PR: 300-599 lines changed and removed size/M Medium PR: 300-599 lines changed labels Jan 6, 2026
@jerm-dro jerm-dro changed the title Migrate telemetry config Vmcp: Migrate telemetry config Jan 6, 2026
@jerm-dro jerm-dro marked this pull request as ready for review January 6, 2026 22:38
@jerm-dro jerm-dro requested review from JAORMX, jhrozek and yrobla January 6, 2026 22:38
dmjb
dmjb previously approved these changes Jan 7, 2026
@jerm-dro jerm-dro force-pushed the jerm/2026-01-06-migrate-basic-config branch from 0909d7c to 6303a20 Compare January 7, 2026 22:33
@jerm-dro jerm-dro force-pushed the jerm/2026-01-06-migrate-telemetry branch from 6f2983e to 23e6ff0 Compare January 7, 2026 22:48
@github-actions github-actions bot added size/M Medium PR: 300-599 lines changed and removed size/M Medium PR: 300-599 lines changed labels Jan 7, 2026
jhrozek
jhrozek previously approved these changes Jan 8, 2026
Base automatically changed from jerm/2026-01-06-migrate-basic-config to main January 8, 2026 15:26
@jerm-dro jerm-dro dismissed stale reviews from jhrozek and dmjb January 8, 2026 15:26

The base branch was changed.

Signed-off-by: Jeremy Drouillard <[email protected]>
Signed-off-by: Jeremy Drouillard <[email protected]>
Signed-off-by: Jeremy Drouillard <[email protected]>
@jerm-dro jerm-dro force-pushed the jerm/2026-01-06-migrate-telemetry branch from ca1a387 to 55e7f22 Compare January 8, 2026 16:08
@github-actions github-actions bot removed the size/M Medium PR: 300-599 lines changed label Jan 8, 2026
@github-actions github-actions bot added the size/M Medium PR: 300-599 lines changed label Jan 8, 2026
Signed-off-by: Jeremy Drouillard <[email protected]>
@github-actions github-actions bot added size/M Medium PR: 300-599 lines changed and removed size/M Medium PR: 300-599 lines changed labels Jan 8, 2026
@github-actions github-actions bot added size/M Medium PR: 300-599 lines changed and removed size/M Medium PR: 300-599 lines changed labels Jan 8, 2026
Signed-off-by: Jeremy Drouillard <[email protected]>
@github-actions github-actions bot added size/M Medium PR: 300-599 lines changed and removed size/M Medium PR: 300-599 lines changed labels Jan 8, 2026
@jerm-dro jerm-dro requested a review from jhrozek January 8, 2026 18:31
@jerm-dro jerm-dro merged commit 64eb12e into main Jan 8, 2026
36 checks passed
@jerm-dro jerm-dro deleted the jerm/2026-01-06-migrate-telemetry branch January 8, 2026 20:24
jerm-dro added a commit that referenced this pull request Jan 8, 2026
Summary
Stacked on #3207
Supports #3125

This PR migrates VMCP spec to use the app config.

Changes
Delete the old spec field.
Add an enabled bit that defaults to false.
Configure defaults via kubebuilder annotations.
Update documentation, examples, and tests.

---------

Signed-off-by: Jeremy Drouillard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Medium PR: 300-599 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants