Fix flacky tests #2178
Merged
Fix flacky tests #2178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* new function for initialize test logger Signed-off-by: NastyaAR <[email protected]>
eleftherias
reviewed
Oct 16, 2025
There was a problem hiding this comment.
Thanks for the PR @NastyaAR!
The overall approach looks good, I've left a few comments inline.
* transfer init test logger function from logger to config_test, make it helper * add cleanup with restoring original logger * make test sequential Signed-off-by: NastyaAR <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2178 +/- ##
==========================================
- Coverage 54.77% 54.75% -0.03%
==========================================
Files 272 272
Lines 25757 25757
==========================================
- Hits 14109 14103 -6
- Misses 10328 10332 +4
- Partials 1320 1322 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eleftherias
reviewed
Oct 21, 2025
There was a problem hiding this comment.
Thanks for the updates @NastyaAR!
Our automated linter flagged some issues, which I've listed in the comments below.
You can run task lint to check if there are any linter issues before committing.
eleftherias
approved these changes
Nov 3, 2025
|
Thank you for your contribution @NastyaAR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem occured due to parallel reading of os.Stderr (logger.Initialize ->logger.InitializeWithEnv -> zap.Config.Build) and writing to it when intercepting stderr in TestFindClientConfigs.
Changes