Strip code snippets through a client interface #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different clients need different ways of stripping away the context in order to analyze just the human text in the user message. Let's start with this as the first method of a client interface. Related: #831
|
I have additional patches that move the cli pipeline step to this interface but I don't want to cause more chaos and rebasing at this moment and make the rebase of the litellm-less branch easier. |
JAORMX
approved these changes
Mar 5, 2025
Comment on lines
+35
to
+41
| class ClineClient(ClientInterface): | ||
| """Cline-specific client interface""" | ||
|
|
||
| _CLINE_FILE_REGEX = re.compile( | ||
| r"(?i)<\s*file_content\s*[^>]*>.*?</\s*file_content\s*>", re.DOTALL | ||
| ) | ||
|
|
There was a problem hiding this comment.
This seems similar to the regex and functionality we have in message_extractor.py. Could we reuse that? It's just a thought.. feel free to disregard the comment if you think it's too hard or doesn't make sense
There was a problem hiding this comment.
ah, this is great. I guess we can at least move the regexes to the same interface or unify them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different clients need different ways of stripping away the context in
order to analyze just the human text in the user message. Let's start
with this as the first method of a client interface.
Related: #831