Guide to retrieve ske outgoing cluster ip #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabh2590
approved these changes
Jul 26, 2024
|
Hey @h3adex, sorry for the delayed response to your PR. Firstly I would like to thank you for this contribution! We always welcome this sort of help and this guide is definitely useful for our users. Also, I really like the writing on it! I will leave some comments below with some details but it looks great overall! Once these comments are addressed, we can merge the PR. |
DiogoFerrao
reviewed
Jul 26, 2024
|
Hi @DiogoFerrao I've applied all of you comments. I've amended all changes to the latest commit. Thank you |
joaopalet
approved these changes
Jul 31, 2024
|
Hi @h3adex, Looks good to me, thanks for the contribution! Can we merge the PR? |
|
Yes. Let's go :-) |
|
We should also inform this issue about this PR. |
joaopalet
added a commit
that referenced
this pull request
Aug 1, 2024
vicentepinto98
pushed a commit
that referenced
this pull request
Oct 24, 2024
* docs: add guide to retrieve outgoing ske ip-address * docs: fix volume attach example * Revert "docs: add guide to retrieve outgoing ske ip-address (#476)" This reverts commit 3c53079. --------- Co-authored-by: Mauritz Uphoff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote some documentation on how to gather the outgoing IP address of the SKE cluster for my own reference. I believe this could be helpful for other developers as well. Please feel free to read through it and share any feedback if something is not clear.
Additionally, I suggest we link this guide to the following issue for better visibility: Issue #102.
Thank you! :-)