chore(fmt) set goimports local-prefixes, apply format#1356
Open
cgoetz-inovex wants to merge 4 commits intomainfrom
Open
chore(fmt) set goimports local-prefixes, apply format#1356cgoetz-inovex wants to merge 4 commits intomainfrom
cgoetz-inovex wants to merge 4 commits intomainfrom
Conversation
Use goimports via golanci-lint / go tool
Fyusel
reviewed
Apr 2, 2026
|
|
||
| tool golang.org/x/tools/cmd/goimports | ||
| tool ( | ||
| github.com/golangci/golangci-lint/v2/cmd/golangci-lint |
Contributor
There was a problem hiding this comment.
Until now we used a fixed version for the linter and updated this from time to time.
Should we keep this behavior in the future?
Contributor
Author
There was a problem hiding this comment.
version is specified here: https://github.com/stackitcloud/terraform-provider-stackit/pull/1356/changes#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R126
that file is a bit noisy
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use goimports via golanci-lint / go tool
Description
relates to #1234
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)