Skip to content

feat(runcommand): implement wait handler for runcommand - #10354

Merged
marceljk merged 4 commits into
stackitcloud:mainfrom
h3adex:feat/add-wait-handler-for-run-command
Sep 3, 2026
Merged

feat(runcommand): implement wait handler for runcommand#10354
marceljk merged 4 commits into
stackitcloud:mainfrom
h3adex:feat/add-wait-handler-for-run-command

Conversation

@h3adex

@h3adex h3adex commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Description

Wait Handler for Terraform PR: stackitcloud/terraform-provider-stackit#1702

Checklist

  • Issue was linked above
  • No generated code was adjusted manually (check comments in file header)
  • Changelogs
    • Changelog in the root directory was adjusted (see here)
    • Changelog(s) of the service(s) were adjusted (see e.g. here)
  • VERSION file(s) of the service(s) were adjusted
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@h3adex
h3adex requested a review from a team as a code owner August 18, 2026 09:56
@h3adex
h3adex force-pushed the feat/add-wait-handler-for-run-command branch 5 times, most recently from d1663ab to 72b2e00 Compare August 18, 2026 12:03
@h3adex
h3adex force-pushed the feat/add-wait-handler-for-run-command branch 2 times, most recently from 1f1ee3a to 6814871 Compare August 24, 2026 11:25
Comment thread services/runcommand/v1api/wait/wait.go Outdated
Comment thread services/runcommand/v1api/wait/wait.go Outdated
@h3adex

h3adex commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

Implemented your suggestions. I've also rebased the PR @SerseusWasTaken

@h3adex
h3adex force-pushed the feat/add-wait-handler-for-run-command branch from 6814871 to d7aa463 Compare August 31, 2026 07:42
Comment thread services/runcommand/CHANGELOG.md Outdated
Comment thread services/runcommand/CHANGELOG.md Outdated
Comment thread services/runcommand/v1api/wait/wait.go Outdated
Comment thread services/runcommand/v2api/wait/wait.go Outdated
@h3adex
h3adex force-pushed the feat/add-wait-handler-for-run-command branch 8 times, most recently from e02b1d9 to 32d08a8 Compare September 2, 2026 07:12
Comment thread CHANGELOG.md Outdated
Comment thread services/runcommand/v2api/wait/wait.go Outdated
Comment thread examples/runcommand/runcommand.go Outdated
@h3adex
h3adex force-pushed the feat/add-wait-handler-for-run-command branch from 16197b9 to 5d29c78 Compare September 2, 2026 11:49
marceljk
marceljk previously approved these changes Sep 2, 2026
SerseusWasTaken
SerseusWasTaken previously approved these changes Sep 2, 2026
@marceljk
marceljk force-pushed the feat/add-wait-handler-for-run-command branch from 5d29c78 to 1e60795 Compare September 3, 2026 06:47
@marceljk
marceljk enabled auto-merge (squash) September 3, 2026 06:47
auto-merge was automatically disabled September 3, 2026 06:49

Head branch was pushed to by a user without write access

@h3adex
h3adex dismissed stale reviews from marceljk and SerseusWasTaken via d7cfb97 September 3, 2026 06:49
@h3adex
h3adex force-pushed the feat/add-wait-handler-for-run-command branch from 1e60795 to d7cfb97 Compare September 3, 2026 06:49
@h3adex
h3adex force-pushed the feat/add-wait-handler-for-run-command branch from d7cfb97 to a6214a4 Compare September 3, 2026 06:50
@marceljk
marceljk enabled auto-merge (squash) September 3, 2026 06:53
@marceljk
marceljk merged commit c0b437f into stackitcloud:main Sep 3, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants