Skip to content

fix(image): update overwrites nullable values #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

Conversation

marceljk
Copy link
Contributor

@marceljk marceljk commented Jul 4, 2025

Description

relates to #833 and #830

feat: add architecture flag #833
fix: update overwrites nullable values #830

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see e.g. here)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@marceljk marceljk changed the title - fix(image): update overwrites nullable values fix(image): update overwrites nullable values Jul 4, 2025
@marceljk marceljk force-pushed the fix/image-command branch from b14c2d8 to 5c763f5 Compare July 7, 2025 07:25
marceljk added 2 commits July 7, 2025 16:52
- fix: update overwrites nullable values #830
@marceljk marceljk force-pushed the fix/image-command branch from 5c763f5 to e723667 Compare July 7, 2025 14:52
@marceljk marceljk requested a review from a team as a code owner July 7, 2025 14:52
@marceljk marceljk enabled auto-merge (squash) July 7, 2025 14:53
@marceljk marceljk merged commit 3bf6282 into main Jul 7, 2025
7 checks passed
@marceljk marceljk deleted the fix/image-command branch July 7, 2025 14:57
Copy link

github-actions bot commented Jul 7, 2025

Merging this branch changes the coverage (2 decrease, 2 increase)

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/image/create 47.31% (+10.61%) 🎉
github.com/stackitcloud/stackit-cli/internal/cmd/image/describe 29.27% (-1.11%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/image/list 37.33% (-1.02%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/image/update 71.43% (+11.43%) 🎉

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/image/create/create.go 47.31% (+10.61%) 167 (+28) 79 (+28) 88 🎉
github.com/stackitcloud/stackit-cli/internal/cmd/image/describe/describe.go 29.27% (-1.11%) 82 (+3) 24 58 (+3) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/image/list/list.go 37.33% (-1.02%) 75 (+2) 28 47 (+2) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/image/update/update.go 71.43% (+11.43%) 105 (+30) 75 (+30) 30 🎉

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/image/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/image/update/update_test.go

1 similar comment
Copy link

github-actions bot commented Jul 7, 2025

Merging this branch changes the coverage (2 decrease, 2 increase)

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/image/create 47.31% (+10.61%) 🎉
github.com/stackitcloud/stackit-cli/internal/cmd/image/describe 29.27% (-1.11%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/image/list 37.33% (-1.02%) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/image/update 71.43% (+11.43%) 🎉

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/stackit-cli/internal/cmd/image/create/create.go 47.31% (+10.61%) 167 (+28) 79 (+28) 88 🎉
github.com/stackitcloud/stackit-cli/internal/cmd/image/describe/describe.go 29.27% (-1.11%) 82 (+3) 24 58 (+3) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/image/list/list.go 37.33% (-1.02%) 75 (+2) 28 47 (+2) 👎
github.com/stackitcloud/stackit-cli/internal/cmd/image/update/update.go 71.43% (+11.43%) 105 (+30) 75 (+30) 30 🎉

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/stackit-cli/internal/cmd/image/create/create_test.go
  • github.com/stackitcloud/stackit-cli/internal/cmd/image/update/update_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants