Extend network commands with new fields #517
Draft
+291
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopalet
reviewed
Nov 28, 2024
| cmd.Flags().Int64(ipv4PrefixLengthFlag, 0, "The prefix length of the IPv4 network") | ||
| cmd.Flags().StringSlice(ipv6DnsNameServersFlag, []string{}, "List of DNS name servers for IPv6") | ||
| cmd.Flags().String(ipv4PrefixFlag, "", "The IPv4 prefix of the network (CIDR)") | ||
| cmd.Flags().String(ipv4GatewayFlag, "", "The IPv4 gateway of a network. If not specified, the first IP of the network will be assigned as the gateway. If 'null' is sent, then the network doesn't have a gateway.") |
There was a problem hiding this comment.
This should be adjusted here, for no network we have the --no-ipv4-network flag
| cmd.Flags().Int64(ipv6PrefixLengthFlag, 0, "The prefix length of the IPv6 network") | ||
| cmd.Flags().String(ipv6PrefixFlag, "", "The IPv6 prefix of the network (CIDR)") | ||
| cmd.Flags().String(ipv6GatewayFlag, "", "The IPv6 gateway of a network. If not specified, the first IP of the network will be assigned as the gateway. If 'null' is sent, then the network doesn't have a gateway.") |
Comment on lines
+146
to
+147
| cmd.Flags().Bool(routedFlag, false, "If set to true, the network is routed and therefore accessible from other networks") | ||
| cmd.Flags().Bool(noIpv4Gateway, false, "If set to true, the network doesn't have an IPv4 gateway.") |
There was a problem hiding this comment.
Soma flag descriptions are ending in . and other not. I think usually we end them without punctuation across other commands
Comment on lines
+162
to
+165
| routed := false | ||
| if network.Routed != nil { | ||
| routed = *network.Routed | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.