refactor: update launch.json and Tiltfile for service paths; modify f… #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the organization of backend services, enhance debugging capabilities, and refactor asynchronous handling in the
admin-api-lib
. The most significant updates involve restructuring file paths for services, adding debugging arguments, and transitioning from threads to asyncio tasks for better concurrency management.Backend Service Path Updates:
.vscode/launch.json
: UpdatedlocalRoot
andremoteRoot
paths to reflect the new organization under theservices
directory forrag-backend
,document-extractor
, andadmin-backend
. [1] [2] [3]Tiltfile
: Adjustedsync
paths inlive_update
for backend services to align with the new directory structure. [1] [2] [3] [4]infrastructure/rag/values.yaml
: Changed--reload-dir
paths for backend services to match the updated directory structure. [1] [2] [3]Debugging Enhancements:
infrastructure/rag/values.yaml
: Added-Xfrozen_modules=off
todebugArgs
forbackend
,adminBackend
, andextractor
to improve Python debugging capabilities. [1] [2] [3]Async Refactoring:
libs/admin-api-lib/src/admin_api_lib/impl/api_endpoints/default_file_uploader.py
: Refactored from threads to asyncio tasks for background processing, including changes to_prune_background_tasks
and usage ofasyncio.to_thread
for blocking calls. [1] [2] [3] [4] [5]libs/admin-api-lib/src/admin_api_lib/impl/api_endpoints/default_source_uploader.py
: Applied similar refactoring withasyncio.to_thread
for blocking calls in_handle_source_upload
. [1] [2] [3]Test Updates:
libs/admin-api-lib/tests/default_file_uploader_test.py
: Updated tests to verify the creation and handling of asyncio background tasks instead of threads. [1] [2]