use fcqn following ansible-lint best practices

.ansible-lint

@@ -0,0 +1,18 @@
+exclude_paths:
+ - .cache/
+ - .tox/
+ - meta/
+ - tests/
+ - molecule/
+warn_list:
+ - schema
+ - jinja[spacing]
+ - name[missing]
+ - name[casing]
+ - galaxy[no-changelog]
+ - galaxy[no-runtime]
+ - galaxy[version-incorrect]
+ - no-changed-when
+ - args[module]
+skip_list:
+ - '106'  # Role name {} does not match ``^[a-z][a-z0-9_]+$`` pattern

.github/release-drafter.yml

@@ -0,0 +1,32 @@
+name-template: "v$RESOLVED_VERSION 🌈"
+tag-template: "v$RESOLVED_VERSION"
+categories:
+  - title: "🚀 Features"
+    labels:
+      - "feature"
+      - "enhancement"
+  - title: "🐛 Bug Fixes"
+    labels:
+      - "fix"
+      - "bugfix"
+      - "bug"
+  - title: "🧰 Maintenance"
+    label: "chore"
+  - title: "🧺 Miscellaneous" #Everything except ABAP
+    label: "misc"
+change-template: "- $TITLE @$AUTHOR (#$NUMBER)"
+change-title-escapes: '\<*_&' # You can add # and @ to disable mentions, and add ` to disable code blocks.
+version-resolver:
+  major:
+    labels:
+      - "major"
+  minor:
+    labels:
+      - "minor"
+  patch:
+    labels:
+      - "patch"
+  default: patch
+template: |
+  ## Changes
+  $CHANGES

.github/workflows/molecule.yml

@@ -0,0 +1,55 @@
+---
+# This is a basic workflow to help you get started with Actions
+name: Molecule
+
+# Controls when the action will run. Triggers the workflow on push or pull request
+# events but only for the master branch
+on:
+  push:
+  pull_request:
+    branches:
+      - master
+      - tags/*
+
+# A workflow run is made up of one or more jobs that can run sequentially or in parallel
+jobs:
+  requirements:
+    # The type of runner that the job will run on
+    runs-on: ubuntu-latest
+    # Steps represent a sequence of tasks that will be executed as part of the job
+    steps:
+      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
+      - uses: actions/checkout@v3
+        with:
+          path: tcharl.ansible_role_libvirt_host
+      - name: install prereq
+        run: |
+          cd tcharl.ansible_role_libvirt_host
+          ansible-galaxy role install -r requirements-standalone.yml
+          ansible-galaxy collection install -r requirements-collections.yml
+  lint:
+    # The type of runner that the job will run on
+    runs-on: ubuntu-latest
+
+    # Steps represent a sequence of tasks that will be executed as part of the job
+    steps:
+      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
+      - uses: actions/checkout@v3
+        with:
+          path: tcharl.ansible_role_libvirt_host
+      - name: update apt
+        run: |
+          sudo apt update
+      - name: install tox apt prerequisite
+        run: |
+          sudo apt -y install sudo python3 python3-pip
+      - name: pip install packages
+        run: |
+          pip3 install wheel setuptools tox
+#      - name: Test KVM conditions fails
+#        run: |
+#          sudo kvm-ok
+      - name: tox lint
+        run: |
+          cd tcharl.ansible_role_libvirt_host
+          tox -e lint

.github/workflows/release-drafter.yml

@@ -0,0 +1,17 @@
+name: Release Drafter
+
+on:
+  push:
+    # branches to consider in the event; optional, defaults to all
+    branches:
+      - main
+      - master
+
+jobs:
+  update_release_draft:
+    runs-on: ubuntu-latest
+    steps:
+      # Drafts your next Release notes as Pull Requests are merged into "master"
+      - uses: release-drafter/release-drafter@v5
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/release-galaxy.yml

@@ -0,0 +1,34 @@
+---
+name: Ansible Galaxy
+on:
+  push:
+    branches:
+      - main
+      - master
+  release:
+    types:
+      - published
+
+jobs:
+  galaxy:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodules: recursive
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v2
+        with:
+          python-version: ${{ matrix.python-version }}
+      - uses: actions/cache@v2
+        with:
+          path: ~/.cache/pip
+          key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements*.txt') }}
+          restore-keys: |
+            ${{ runner.os }}-pip-
+      - name: Install dependencies
+        run: |
+          python -m pip install --upgrade pip
+          pip install -r requirements.txt
+      - name: Trigger a new import on Galaxy.
+        run: ansible-galaxy role import --api-key ${{ secrets.GALAXY_API_KEY }} $(echo ${{ github.repository }} | cut -d/ -f1) $(echo ${{ github.repository }} | cut -d/ -f2)

.gitignore

@@ -0,0 +1,3 @@
+.idea
+.cache
+__pycache__

.tox/converge/.tox-info.json

@@ -0,0 +1,36 @@
+{
+  "ToxEnv": {
+    "name": "converge",
+    "type": "VirtualEnvRunner"
+  },
+  "Python": {
+    "version_info": [
+      3,
+      11,
+      3,
+      "final",
+      0
+    ],
+    "executable": "/usr/local/Cellar/[email protected]/3.11.3/Frameworks/Python.framework/Versions/3.11/bin/python3.11",
+    "virtualenv version": "20.23.0"
+  },
+  "PythonRun": {
+    "deps": {
+      "options": [],
+      "requirements": [
+        "ansible-lint",
+        "flake8",
+        "jmespath",
+        "molecule-plugins[vagrant]",
+        "pytest-testinfra",
+        "python-vagrant",
+        "yamllint"
+      ],
+      "constraints": [],
+      "constraint_options": {
+        "constrain_package_deps": false,
+        "use_frozen_constraints": false
+      }
+    }
+  }
+}

.travis.yml

@@ -1,35 +1,44 @@
 ---
-language: python
-python: "2.7"
 
-# Use the new container infrastructure
-sudo: false
+dist: jammy
 
-# Install ansible
+language: python
+python:
+  - "3.11"
 addons:
   apt:
+    sources:
+      - sourceline: 'deb [arch=amd64] https://apt.releases.hashicorp.com $(lsb_release -cs) main'
+        key_url: 'https://apt.releases.hashicorp.com/gpg'
+    update: true
     packages:
-      - python-pip
+      - bridge-utils
+      - dnsmasq-base
+      - ebtables
+      - virtinst
+      - libvirt-dev
+      - libvirt-daemon-system
+      - qemu-kvm
+      - qemu-utils
+      - ruby-dev
+      - ca-certificates
+      - curl
+      - gcc
+      - iproute2
+      - sudo
+      - vagrant
 
 install:
-  # Install ansible
-  - pip install ansible ansible-lint
-
-  # Check ansible version
-  - ansible --version
-
-  # Create ansible.cfg with correct roles_path
-  - printf '[defaults]\nroles_path=../' >ansible.cfg
-
-  # Compensate for repo name being different to the role
-  - ln -s $(pwd) ../stackhpc.libvirt-host
+#  - wget https://releases.hashicorp.com/vagrant/$VAGRANT_VER/vagrant_"$VAGRANT_VER"_x86_64.deb
+#  - sudo apt -y install ./vagrant_"$VAGRANT_VER"_x86_64.deb
+  - vagrant plugin install vagrant-libvirt
+  - pip install wheel pyopenssl tox
+  - sudo chmod o+rwx /var/run/libvirt/libvirt-sock
+  - sh configure
 
 script:
-  # Run Ansible lint against the role
-  - ansible-lint tasks/main.yml
-
-  # Basic role syntax check
-  - ansible-playbook tests/test.yml -i tests/inventory --syntax-check
-
-notifications:
-  webhooks: https://galaxy.ansible.com/api/v1/notifications/
+  - mv ../ansible-role-libvirt-host ../tcharl.ansible_role_libvirt_host
+  - travis_wait 30 tox -e test-exec -- --scenario-name kvm
+branches:
+  only:
+    - master

.yamllint

@@ -0,0 +1,35 @@
+---
+# Based on ansible-lint config
+extends: default
+ignore: |
+  .cache
+  .tox
+rules:
+  braces:
+    max-spaces-inside: 1
+    level: error
+  brackets:
+    max-spaces-inside: 1
+    level: error
+  colons:
+    max-spaces-after: -1
+    level: error
+  commas:
+    max-spaces-after: -1
+    level: error
+  comments: disable
+  comments-indentation: disable
+  document-start: disable
+  empty-lines:
+    max: 3
+    level: error
+  hyphens:
+    level: error
+  indentation: disable
+  key-duplicates: enable
+  line-length: disable
+  new-line-at-end-of-file: disable
+  new-lines:
+    type: unix
+  trailing-spaces: disable
+  truthy: disable

CHANGELOG.md

@@ -0,0 +1 @@
+see release drafter results

README.md

@@ -35,15 +35,16 @@ should be a dict containing the following items:
 `libvirt_host_networks` is a list of networks to define and start. Each item
 should be a dict containing the following items:
 - `name` The name of the network.
-- `mode` The forwarding mode of the network, `bridge`, `route` and `nat` are
-  supported.
+- `mode` The forwarding mode of the network, `bridge`, `route`, `open` and `nat` are
+  supported. Leave empty for a isolated network mode.
 - `bridge` The name of the bridge interface for this network.
-- `ip` IP address of the virtual bridge, mandatory for `route` and `nat` mode.
-- `netmask` Netmask of the virtual bridge, mandatory for `route` and `nat` mode.
-- `domain` DNS domain name for `route` and `nat` mode, default to the network
+- `zone` the firewalld zone for the bridge (defaults to public)  
+- `ip` IP address of the virtual bridge, mandatory for `route`, `open` and `nat` mode.
+- `netmask` Netmask of the virtual bridge, mandatory for `route`, `open` and `nat` mode.
+- `domain` DNS domain name for `route`, `open` and `nat` mode, default to the network
    name (optional).
-- `dhcp_start` First IP of the DHCP range in `route` or `nat` mode (optional).
-- `dhcp_end` Last IP of the DHCP range in `route` or `nat` mode (optional).
+- `dhcp_start` First IP of the DHCP range in `route`, `open` or `nat` mode (optional).
+- `dhcp_end` Last IP of the DHCP range in `route`, `open` or `nat` mode (optional).
 - `routes` Optional list of additionals routes defined as following:
   - `address` Address of the route, required.
   - `prefix` Prefix of the route, required.
@@ -193,7 +194,7 @@ storage pools.
 Dependencies
 ------------
 
-None
+* [The LVM role](https://github.com/mrlesmithjr/ansible-manage-lvm) You can install it using `ansible-galaxy install -r requirements.yml --roles-p ../community`
 
 Example Playbook
 ----------------
@@ -203,6 +204,11 @@ Example Playbook
       hosts: all
       roles:
         - role: stackhpc.libvirt-host
+          lvm_groups: # see according properties on [The LVM role](https://github.com/mrlesmithjr/ansible-manage-lvm)
+            - vgname: libvirtvg
+              disks:
+                - /dev/sdb1
+              create: true
           libvirt_host_pools:
             - name: my-pool
               type: dir
@@ -212,11 +218,8 @@ Example Playbook
               owner: my-user
               group: my-group
             - name: lvm_pool
-              type: logical
-              source: vg1
-              target: /dev/vg1
-              pvs:
-                - /dev/sda3
+              type: lvm2
+              source: libvirtvg
             - name: rbd-pool
               type: rbd
               source: rbd

configure

@@ -0,0 +1,3 @@
+#!/usr/bin/env bash
+
+vagrant plugin install vagrant-persistent-storage