Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(astro): add support for footer override #423

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(astro): add support for footer override #423

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d3dbe48
feat(dev): add support for footer override
RonithManikonda Nov 7, 2024
7878c48
chore: run `pnpm run lint --fix`
AriPerkkio Nov 22, 2024
40f7f2e
chore: run `pnpm run test -u` in `packages/cli`
AriPerkkio Nov 22, 2024
1c6f358
Merge remote-tracking branch 'upstream/main' into ronith/overriding-f…
AriPerkkio Nov 22, 2024
696ee1b
feat(vite-plugins): add support for overriding Footer component
RonithManikonda Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/astro/src/default/components/Footer.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<nav class="bg-tk-elements-footer-backgroundColor border-t border-tk-elements-app-borderColor flex justify-between p-4">
<div class="flex-1">
<slot name="terms" />
</div>
<div class="flex-1">
<slot name="contact-info" />
</div>
<div class="flex-1">
<slot name="copyright" />
</div>
</nav>
14 changes: 14 additions & 0 deletions packages/astro/src/default/components/FooterWrapper.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
// FooterWrapper.astro
import { Footer } from 'tutorialkit:override-components';
import Terms from './Terms.astro';
import ContactInfo from './ContactInfo.astro';

const currentYear = new Date().getFullYear();
---

<Footer>
<Terms slot="terms" />
<ContactInfo slot="contact-info" />
<p slot="copyright">© {currentYear} Your Company. All rights reserved.</p>
</Footer>
2 changes: 2 additions & 0 deletions packages/cli/tests/__snapshots__/create-tutorial.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,8 @@ exports[`create and eject a project 1`] = `
"public/logo.svg",
"src",
"src/components",
"src/components/Footer.astro",
"src/components/FooterWrapper.astro",
"src/components/HeadTags.astro",
"src/components/LoginButton.tsx",
"src/components/Logo.astro",
Expand Down