-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: release workflow #106
ci: release workflow #106
Conversation
Run & review this pull request in StackBlitz Codeflow. |
dd152ad
to
29da35d
Compare
24b3bf5
to
df1bca6
Compare
permissions: | ||
contents: write | ||
id-token: write |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are required for --provenance
flag.
env: | ||
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to manually add this secret to the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@d3lm I think if you can add @stackblitz-gitops to the packages, then we should be able to reuse the token of @stackblitz-gitops.
@apai4 Do you think that would be fine? Or should we have a different token?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pinged Pai about this because I cannot add NPM access tokens since I don't have permissions to generate them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll create a new token for stackblitz-devops
on NPM for this repo and add it to secrets.NPM_TOKEN
. stackblitz-devops
will need write access to the NPM package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The token has been created and added to the repo. Let me know if it works once stackblitz-gitops
is granted access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@d3lm can you grant access to stackblitz-gitops
on all the packages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I can do that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invite is out. I think @apai4 needs to accept it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@d3lm do you have permissions to check if this is completed now? Publish step failed at https://github.com/stackblitz/tutorialkit/actions/runs/9791481416/job/27035364611
df1bca6
to
4317768
Compare
Need to recheck the integration tests again. They started to fail for me locally after rebase. Would appreciate if someone else could also try them locally. 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor comments. Great work @AriPerkkio 👏
54a386c
to
64c43e2
Compare
32fc233
to
eba02b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work on this @AriPerkkio ! 😃 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Only minor remarks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 💪 👏 🔥
Adds scripts for performing releases.
Prepare release PR
workflow:This workflow will bump versions and generate changelogs for all packages, except CLI. It creates a PR like chore: release @tutorialkit packages and create-tutorial, version: 0.0.1-alpha.23 AriPerkkio/tutorialkit#26
Merging the PR triggers another workflow with two jobs: