Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for trino 455, remove old opa authorizer code #638

Merged
merged 7 commits into from
Sep 5, 2024

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Sep 4, 2024

Description

Part of stackabletech/issues#626

  • Add support for Trino version 455
  • Remove support for Trino versions 414 and 442
  • Remove OPA authorizer code for older Trino versions

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Tests passed

--- PASS: kuttl (1447.13s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/orphaned-resources_trino-latest-455_openshift-false (93.22s)
        --- PASS: kuttl/harness/tls_trino-latest-455_use-authentication-false_use-tls-true_use-internal-tls-false_openshift-false (123.55s)
        --- PASS: kuttl/harness/tls_trino-latest-455_use-authentication-true_use-tls-true_use-internal-tls-true_openshift-false (126.78s)
        --- PASS: kuttl/harness/tls_trino-latest-455_use-authentication-true_use-tls-true_use-internal-tls-false_openshift-false (91.05s)
        --- PASS: kuttl/harness/tls_trino-latest-455_use-authentication-true_use-tls-false_use-internal-tls-false_openshift-false (68.24s)
        --- PASS: kuttl/harness/tls_trino-latest-455_use-authentication-true_use-tls-false_use-internal-tls-true_openshift-false (76.04s)
        --- PASS: kuttl/harness/tls_trino-latest-455_use-authentication-false_use-tls-false_use-internal-tls-false_openshift-false (70.04s)
        --- PASS: kuttl/harness/tls_trino-latest-455_use-authentication-false_use-tls-true_use-internal-tls-true_openshift-false (85.64s)
        --- PASS: kuttl/harness/tls_trino-latest-455_use-authentication-false_use-tls-false_use-internal-tls-true_openshift-false (74.96s)
        --- PASS: kuttl/harness/smoke_trino-455_hive-4.0.0_opa-0.66.0_hdfs-3.4.0_zookeeper-3.9.2_s3-use-tls-false_openshift-false (418.97s)
        --- PASS: kuttl/harness/smoke_trino-451_hive-3.1.3_opa-0.66.0_hdfs-3.4.0_zookeeper-3.9.2_s3-use-tls-false_openshift-false (372.61s)
        --- PASS: kuttl/harness/smoke_trino-451_hive-3.1.3_opa-0.66.0_hdfs-3.4.0_zookeeper-3.9.2_s3-use-tls-true_openshift-false (442.21s)
        --- PASS: kuttl/harness/smoke_trino-455_hive-3.1.3_opa-0.66.0_hdfs-3.4.0_zookeeper-3.9.2_s3-use-tls-false_openshift-false (445.15s)
        --- PASS: kuttl/harness/cluster-operation_trino-latest-455_openshift-false (103.28s)
        --- PASS: kuttl/harness/smoke_trino-455_hive-3.1.3_opa-0.66.0_hdfs-3.4.0_zookeeper-3.9.2_s3-use-tls-true_openshift-false (432.06s)
        --- PASS: kuttl/harness/authentication_trino-latest-455_ldap-use-tls-true_openshift-false (308.13s)
        --- PASS: kuttl/harness/resources_trino-latest-455_openshift-false (55.64s)
        --- PASS: kuttl/harness/opa-authorization_trino-latest-455_hive-latest-4.0.0_opa-0.66.0_keycloak-25.0.0_openshift-false (322.12s)
        --- PASS: kuttl/harness/smoke_trino-451_hive-4.0.0_opa-0.66.0_hdfs-3.4.0_zookeeper-3.9.2_s3-use-tls-false_openshift-false (362.97s)
        --- PASS: kuttl/harness/smoke_trino-451_hive-4.0.0_opa-0.66.0_hdfs-3.4.0_zookeeper-3.9.2_s3-use-tls-true_openshift-false (391.36s)
        --- PASS: kuttl/harness/logging_trino-455_openshift-false (94.47s)
        --- PASS: kuttl/harness/authentication_trino-latest-455_ldap-use-tls-false_openshift-false (290.56s)
        --- PASS: kuttl/harness/logging_trino-451_openshift-false (86.77s)
        --- PASS: kuttl/harness/smoke_trino-455_hive-4.0.0_opa-0.66.0_hdfs-3.4.0_zookeeper-3.9.2_s3-use-tls-true_openshift-false (405.29s)
PASS

Dependencies

  1. 2 of 2

Reviewer

Acceptance

Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please update the supported versions in docs/modules/trino/partials/supported-versions.adoc as well.

rust/operator-binary/src/config/jvm.rs Show resolved Hide resolved
maltesander
maltesander previously approved these changes Sep 5, 2024
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when tests pass

@xeniape xeniape added this pull request to the merge queue Sep 5, 2024
Merged via the queue into main with commit f2db83e Sep 5, 2024
31 checks passed
@xeniape xeniape deleted the trino-455 branch September 5, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt OPA authorization documentation/examples/tests once v414 is no longer supported
3 participants