Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: Support podOverrides #440

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat: Support podOverrides #440

wants to merge 3 commits into from

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Jul 4, 2023 •
edited by lfrancke
Loading

Description

Part of stackabletech/issues#346
Supersedes #433

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Beta Give feedback

Reviewer
Beta Give feedback

Acceptance
Beta Give feedback

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer mentioned this pull request Jul 4, 2023
Closed
@sbernauer sbernauer mentioned this pull request Jul 4, 2023
Closed
@adwk67 adwk67 self-requested a review July 4, 2023 13:57
@sbernauer
Copy link
Member Author

Started https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/80/

adwk67
adwk67 approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % minor typos

tests/templates/kuttl/resources/10-assert.yaml.j2 Outdated Show resolved Hide resolved
tests/templates/kuttl/resources/10-assert.yaml.j2 Outdated Show resolved Hide resolved
@sbernauer @adwk67
Apply suggestions from code review
17da13c 
Co-authored-by: Andrew Kenworthy <[email protected]>
@sbernauer
Copy link
Member Author

bors r+
Resources test failed, fixed it and passed locally

bors bot pushed a commit that referenced this pull request Jul 5, 2023
@sbernauer
feat: Support podOverrides (#440)
3ba2312 
# Description

Part of stackabletech/issues#346
Supersedes #433
@sbernauer sbernauer self-assigned this Jul 5, 2023
@bors
Copy link
Contributor

bors bot commented Jul 5, 2023

Pull request successfully merged into main.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Support podOverrides [Merged by Bors] - feat: Support podOverrides Jul 5, 2023
@bors bors bot closed this Jul 5, 2023
@bors bors bot deleted the feat/pod-overrides-2 branch July 5, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees

@sbernauer sbernauer

Labels
release/2023-07
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbernauer @adwk67 @lfrancke