Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy apps with dynamic dependencies. #281

Merged
merged 38 commits into from
Sep 25, 2023

Conversation

razvan
Copy link
Member

@razvan razvan commented Sep 11, 2023

Description

BUILDS ON TOP OF #277. Probably makes sense to review after #277 has been merged.

Fixes #141

Fix for applications with dynamic dependencies:

  • create folder for ivy downloads
  • use spark.jars.packages instead of --packages
  • added test with iceberg

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

@razvan razvan self-assigned this Sep 11, 2023
@razvan
Copy link
Member Author

razvan commented Sep 12, 2023

@razvan razvan marked this pull request as ready for review September 12, 2023 08:50
@razvan razvan requested a review from a team September 12, 2023 08:50
@fhennig fhennig requested review from fhennig and removed request for a team September 14, 2023 08:33
@razvan
Copy link
Member Author

razvan commented Sep 25, 2023

@razvan razvan added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit 519ec08 Sep 25, 2023
30 checks passed
@bors bors bot deleted the feat/extensions-with-config-overrides branch September 25, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executors don't resolve dependencies
3 participants