Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stackable-versioned): Add YAML serialization for merged CRD #884

Merged
merged 10 commits into from
Oct 9, 2024

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Oct 8, 2024

Part of stackabletech/issues#642

This generates helper functions to write the merged CRD to a file and to stdout.

Reviewer

@Techassi Techassi self-assigned this Oct 8, 2024
@Techassi Techassi changed the title feat: Add stackable-shared crate feat(stackable-versioned): Add YAML serialization for merged CRD Oct 8, 2024
@Techassi Techassi force-pushed the feat/stackable-versioned-yaml-output branch from b033afe to e763970 Compare October 9, 2024 06:21
@Techassi Techassi marked this pull request as ready for review October 9, 2024 06:26
@Techassi Techassi marked this pull request as draft October 9, 2024 06:26
@Techassi Techassi marked this pull request as ready for review October 9, 2024 12:22
NickLarsenNZ
NickLarsenNZ previously approved these changes Oct 9, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit daf9908 Oct 9, 2024
10 checks passed
@Techassi Techassi deleted the feat/stackable-versioned-yaml-output branch October 9, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants