Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(stackable-versioned): Rework version enum for merged_crd #875

Merged
merged 4 commits into from
Sep 24, 2024
Merged

refactor(stackable-versioned): Rework version enum for merged_crd #875

merged 4 commits into from
Sep 24, 2024

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Sep 24, 2024 •
edited
Loading

Part of stackabletech/issues#507, follow-up of #872 (comment)

This PR adjusts the version enum generation used in the merged_crd function.

let merged_crd = Foo::merged_crd(Foo::V1).unwrap();
println!("{}", serde_yaml::to_string(&merged_crd).unwrap());

@Techassi Techassi self-assigned this Sep 24, 2024
@Techassi Techassi mentioned this pull request Sep 24, 2024
Closed
@Techassi Techassi marked this pull request as ready for review September 24, 2024 11:51
NickLarsenNZ
NickLarsenNZ previously approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some suggestions for improvements and future proofing.

crates/stackable-versioned-macros/src/codegen/vstruct/mod.rs Outdated Show resolved Hide resolved
crates/stackable-versioned-macros/src/codegen/vstruct/mod.rs Show resolved Hide resolved
NickLarsenNZ
NickLarsenNZ approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi mentioned this pull request Sep 24, 2024
Merged
@Techassi Techassi added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 7ba94b5 Sep 24, 2024
10 checks passed
@Techassi Techassi deleted the refactor/crd-versioning-version-enum branch September 24, 2024 13:13
@Techassi Techassi mentioned this pull request Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@Techassi Techassi

Labels
None yet
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Techassi @NickLarsenNZ