Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Logback configuration #874

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix: Logback configuration #874

merged 1 commit into from
Sep 24, 2024

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Sep 24, 2024 •
edited
Loading

Description

Fix the logback configuration for logback versions from 1.3.6/1.4.6 to 1.3.11/1.4.11.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Beta Give feedback

Reviewer
Beta Give feedback

Acceptance
Beta Give feedback

@siegfriedweber siegfriedweber self-assigned this Sep 24, 2024
@siegfriedweber siegfriedweber marked this pull request as ready for review September 24, 2024 11:11
@siegfriedweber siegfriedweber requested a review from a team September 24, 2024 11:11
NickLarsenNZ
NickLarsenNZ approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the comment

@siegfriedweber siegfriedweber added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 8fcf506 Sep 24, 2024
10 checks passed
@siegfriedweber siegfriedweber deleted the fix/logback-configuration branch September 24, 2024 11:45
@lfrancke
Copy link
Member

Whoah....indeed. Thanks for catching this. This sounds painful.

@sbernauer sbernauer mentioned this pull request Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@siegfriedweber siegfriedweber

Labels
None yet
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siegfriedweber @lfrancke @NickLarsenNZ