fix!: Avoid clashing volumes and mounts #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickLarsenNZ
previously approved these changes
Sep 20, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
clippy
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/builder/pod/container.rs:252:10
|
30 | / ClashingVolumeMountMountPath {
31 | | existing_volume_mount: VolumeMount,
32 | | new_volume_mount: VolumeMount,
33 | | },
| |_____- the largest variant contains at least 304 bytes
...
252 | ) -> Result<&mut Self> {
| ^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `builder::pod::container::Error`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/builder/pod/container.rs:328:57
|
30 | / ClashingVolumeMountMountPath {
31 | | existing_volume_mount: VolumeMount,
32 | | new_volume_mount: VolumeMount,
33 | | },
| |_____- the largest variant contains at least 304 bytes
...
328 | fn validate_container_name(container_name: &str) -> Result<()> {
| ^^^^^^^^^^
|
= help: try reducing the size of `builder::pod::container::Error`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/product_logging/framework.rs:1428:6
|
39 | / CreateContainer {
40 | | source: builder::pod::container::Error,
41 | | },
| |_____- the largest variant contains at least 304 bytes
...
44 | / AddVolumeMounts {
45 | | source: builder::pod::container::Error,
46 | | },
| |_____- the variant `AddVolumeMounts` contains at least 304 bytes
...
1428 | ) -> Result {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `product_logging::framework::LoggingError`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/commons/authentication/ldap.rs:77:35
|
39 | / AddVolumeMounts {
40 | | source: builder::pod::container::Error,
41 | | },
| |_____- the largest variant contains at least 304 bytes
...
77 | pub fn endpoint_url(&self) -> Result {
| ^^^^^^^^^^^
|
= help: try reducing the size of `commons::authentication::ldap::Error`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/commons/authentication/ldap.rs:111:10
|
39 | / AddVolumeMounts {
40 | | source: builder::pod::container::Error,
41 | | },
| |_____- the largest variant contains at least 304 bytes
...
111 | ) -> Result<()> {
| ^^^^^^^^^^
|
= help: try reducing the size of `commons::authentication::ldap::Error`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/commons/authentication/ldap.rs:125:41
|
39 | / AddVolumeMounts {
40 | | source: builder::pod::container::Error,
41 | | },
| |_____- the largest variant contains at least 304 bytes
...
125 | pub fn volumes_and_mounts(&self) -> Result<(Vec, Vec)> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `commons::authentication::ldap::Error`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/commons/s3/helpers.rs:51:31
|
51 | pub fn endpoint(&self) -> Result {
| ^^^^^^^^^^^^^^^^^^^^
|
::: crates/stackable-operator/src/commons/s3/mod.rs:41:5
|
41 | / AddVolumeMounts {
42 | | source: builder::pod::container::Error,
43 | | },
| |_____- the largest variant contains at least 304 bytes
|
= help: try reducing the size of `commons::s3::S3Error`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/commons/s3/helpers.rs:86:10
|
86 | ) -> Result<(), S3Error> {
| ^^^^^^^^^^^^^^^^^^^
|
::: crates/stackable-operator/src/commons/s3/mod.rs:41:5
|
41 | / AddVolumeMounts {
42 | | source: builder::pod::container::Error,
43 | | },
| |_____- the largest variant contains at least 304 bytes
|
= help: try reducing the size of `commons::s3::S3Error`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/commons/s3/helpers.rs:99:41
|
99 | pub fn volumes_and_mounts(&self) -> Result<(Vec, Vec), S3Error> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: crates/stackable-operator/src/commons/s3/mod.rs:41:5
|
41 | / AddVolumeMounts {
42 | | source: builder::pod::container::Error,
43 | | },
| |_____- the largest variant contains at least 304 bytes
|
= help: try reducing the size of `commons::s3::S3Error`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/commons/tls_verification.rs:53:10
|
26 | / AddVolumeMounts {
27 | | source: builder::pod::container::Error,
28 | | },
| |_____- the largest variant contains at least 304 bytes
...
53 | ) -> Result<(), TlsClientDetailsError> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `commons::tls_verification::TlsClientDetailsError`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/commons/tls_verification.rs:69:10
|
26 | / AddVolumeMounts {
27 | | source: builder::pod::container::Error,
28 | | },
| |_____- the largest variant contains at least 304 bytes
...
69 | ) -> Result<(Vec, Vec), TlsClientDetailsError> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `commons::tls_verification::TlsClientDetailsError`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/product_logging/framework.rs:1428:6
|
39 | / CreateContainer {
40 | | source: builder::pod::container::Error,
41 | | },
| |_____- the largest variant contains at least 304 bytes
...
44 | / AddVolumeMounts {
45 | | source: builder::pod::container::Error,
46 | | },
| |_____- the variant `AddVolumeMounts` contains at least 304 bytes
...
1428 | ) -> Result {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `product_logging::framework::LoggingError`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
razvan
reviewed
Sep 23, 2024
NickLarsenNZ
previously requested changes
Sep 23, 2024
Co-authored-by: Techassi <[email protected]>
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
clippy
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/commons/tls_verification.rs:53:10
|
26 | / AddVolumeMounts {
27 | | source: builder::pod::container::Error,
28 | | },
| |_____- the largest variant contains at least 168 bytes
...
53 | ) -> Result<(), TlsClientDetailsError> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `commons::tls_verification::TlsClientDetailsError`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/commons/tls_verification.rs:69:10
|
26 | / AddVolumeMounts {
27 | | source: builder::pod::container::Error,
28 | | },
| |_____- the largest variant contains at least 168 bytes
...
69 | ) -> Result<(Vec, Vec), TlsClientDetailsError> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `commons::tls_verification::TlsClientDetailsError`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/commons/authentication/ldap.rs:77:35
|
39 | / AddVolumeMounts {
40 | | source: builder::pod::container::Error,
41 | | },
| |_____- the largest variant contains at least 168 bytes
...
77 | pub fn endpoint_url(&self) -> Result {
| ^^^^^^^^^^^
|
= help: try reducing the size of `commons::authentication::ldap::Error`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/commons/authentication/ldap.rs:111:10
|
39 | / AddVolumeMounts {
40 | | source: builder::pod::container::Error,
41 | | },
| |_____- the largest variant contains at least 168 bytes
...
111 | ) -> Result<()> {
| ^^^^^^^^^^
|
= help: try reducing the size of `commons::authentication::ldap::Error`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/commons/authentication/ldap.rs:125:41
|
39 | / AddVolumeMounts {
40 | | source: builder::pod::container::Error,
41 | | },
| |_____- the largest variant contains at least 168 bytes
...
125 | pub fn volumes_and_mounts(&self) -> Result<(Vec, Vec)> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `commons::authentication::ldap::Error`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/product_logging/framework.rs:1440:6
|
39 | / CreateContainer {
40 | | source: builder::pod::container::Error,
41 | | },
| |_____- the largest variant contains at least 168 bytes
...
44 | / AddVolumeMounts {
45 | | source: builder::pod::container::Error,
46 | | },
| |_____- the variant `AddVolumeMounts` contains at least 168 bytes
...
1440 | ) -> Result {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `product_logging::framework::LoggingError`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/commons/s3/helpers.rs:51:31
|
51 | pub fn endpoint(&self) -> Result {
| ^^^^^^^^^^^^^^^^^^^^
|
::: crates/stackable-operator/src/commons/s3/mod.rs:41:5
|
41 | / AddVolumeMounts {
42 | | source: builder::pod::container::Error,
43 | | },
| |_____- the largest variant contains at least 168 bytes
|
= help: try reducing the size of `commons::s3::S3Error`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/commons/s3/helpers.rs:86:10
|
86 | ) -> Result<(), S3Error> {
| ^^^^^^^^^^^^^^^^^^^
|
::: crates/stackable-operator/src/commons/s3/mod.rs:41:5
|
41 | / AddVolumeMounts {
42 | | source: builder::pod::container::Error,
43 | | },
| |_____- the largest variant contains at least 168 bytes
|
= help: try reducing the size of `commons::s3::S3Error`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/commons/s3/helpers.rs:99:41
|
99 | pub fn volumes_and_mounts(&self) -> Result<(Vec, Vec), S3Error> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
::: crates/stackable-operator/src/commons/s3/mod.rs:41:5
|
41 | / AddVolumeMounts {
42 | | source: builder::pod::container::Error,
43 | | },
| |_____- the largest variant contains at least 168 bytes
|
= help: try reducing the size of `commons::s3::S3Error`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/commons/tls_verification.rs:53:10
|
26 | / AddVolumeMounts {
27 | | source: builder::pod::container::Error,
28 | | },
| |_____- the largest variant contains at least 168 bytes
...
53 | ) -> Result<(), TlsClientDetailsError> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `commons::tls_verification::TlsClientDetailsError`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/commons/tls_verification.rs:69:10
|
26 | / AddVolumeMounts {
27 | | source: builder::pod::container::Error,
28 | | },
| |_____- the largest variant contains at least 168 bytes
...
69 | ) -> Result<(Vec, Vec), TlsClientDetailsError> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `commons::tls_verification::TlsClientDetailsError`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
🚫 [clippy] reported by reviewdog 🐶
error: the `Err`-variant returned from this function is very large
--> crates/stackable-operator/src/product_logging/framework.rs:1440:6
|
39 | / CreateContainer {
40 | | source: builder::pod::container::Error,
41 | | },
| |_____- the largest variant contains at least 168 bytes
...
44 | / AddVolumeMounts {
45 | | source: builder::pod::container::Error,
46 | | },
| |_____- the variant `AddVolumeMounts` contains at least 168 bytes
...
1440 | ) -> Result {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `product_logging::framework::LoggingError`, for example by boxing large elements or replacing it with `Box`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
Techassi
approved these changes
Sep 26, 2024
sbernauer
dismissed
NickLarsenNZ’s stale review
We had a meeting together with Techassi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discovered in stackabletech/trino-operator#646
Definition of Done Checklist
Author
Reviewer
Acceptance