feat(stackable-versioned): Add support for type changes of fields #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techassi
force-pushed
the
feat/crd-versioning-type-change
branch
from
a1fd53f
to
0bfa8da
Compare
The current implementation is very brittle and less than ideal. It currently only produces correct code in the struct definitions, but not in the From impls. For that reason, test files currently skip the From impl generation. I have a bunch of thoughts on how to improve the situation, but I would like to tackle these changes in follow-up commits.
Techassi
force-pushed
the
feat/crd-versioning-type-change
branch
from
f2c367e
to
118ed09
Compare
|
I would like to adjust some of the internal types and how the validation works. These changes are however not included in this PR, because it proved to be very difficult to implement the changes at the current moment. I will tackle this in future PRs. Also see TedDriggs/darling#304. It also keeps the PR small and focuses on the type change feature. |
Co-authored-by: Nick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/issues#507
This PR adds support for type changes of struct fields. This is done by renaming the
renamed()action tochanged()and adding a new parameterfrom_typeto it. Additionally,fromwill be renamed tofrom_name.Reviewer