Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stackable-versioned): Validation error reporting #842

Merged
merged 7 commits into from
Aug 21, 2024
Merged

fix(stackable-versioned): Validation error reporting #842

merged 7 commits into from
Aug 21, 2024

Conversation

Techassi
Copy link
Member

This fixes two issues:

  • Variant rename validation errors showed up at the wrong place. It now used the span of the variant ident.
  • Variants not using PascalCase (for example: My_Variant) included the leading underscore in the generated variant name.

Reviewer
Beta Give feedback

@Techassi Techassi self-assigned this Aug 21, 2024
NickLarsenNZ
NickLarsenNZ previously approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crates/stackable-versioned-macros/src/codegen/common/mod.rs Outdated Show resolved Hide resolved
crates/stackable-versioned-macros/src/codegen/common/mod.rs Outdated Show resolved Hide resolved
crates/stackable-versioned-macros/src/codegen/common/mod.rs Outdated Show resolved Hide resolved
NickLarsenNZ
NickLarsenNZ requested changes Aug 21, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 chainzes

crates/stackable-versioned-macros/src/codegen/common/mod.rs Outdated Show resolved Hide resolved
crates/stackable-versioned-macros/src/codegen/common/mod.rs Outdated Show resolved Hide resolved
@Techassi @NickLarsenNZ
chore: Apply suggestions
87cc5be 
This snuck in because rust-analyzer doesn't remove trailing commas the same way it does for the format! macro.

Co-authored-by: Nick <[email protected]>
NickLarsenNZ
NickLarsenNZ approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Aug 21, 2024
Merged via the queue into main with commit 79252b2 Aug 21, 2024
19 of 20 checks passed
@Techassi Techassi deleted the fix/crd-versioning-validation-errors branch August 21, 2024 10:07
@Techassi Techassi mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickLarsenNZ NickLarsenNZ NickLarsenNZ approved these changes

Assignees

@Techassi Techassi

Labels
None yet
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Techassi @NickLarsenNZ