Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: swap priority order of role group config and role overrides in configuration merging #841

Merged
merged 7 commits into from
Aug 22, 2024

Conversation

xeniape
Copy link
Member

@xeniape xeniape commented Aug 19, 2024

Description

Implementation of https://github.com/stackabletech/decisions/issues/22

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

@xeniape xeniape requested a review from Techassi August 20, 2024 12:31
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one small suggestion.

crates/stackable-operator/src/product_config_utils.rs Outdated Show resolved Hide resolved
@xeniape xeniape added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit 004b9bd Aug 22, 2024
20 checks passed
@xeniape xeniape deleted the fix/change-override-priority-order branch August 22, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants