Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java security properties #631

Closed
wants to merge 8 commits into from
Closed

Java security properties #631

wants to merge 8 commits into from

Conversation

razvan
Copy link
Member

@razvan razvan commented Aug 4, 2023

  • Added jvm module
  • Added default security props.
  • Fix system property value.
  • Add labels to jvm security config map
  • Set more labels.

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

Acceptance

@razvan
Copy link
Member Author

razvan commented Aug 8, 2023

Feedback from @sbernauer:

  • properties: HashMap<String, Option> -> properties: HashMap<String, String>
  • warum nicht in rolegroup cm inkludieren?
  • default nicht via serde, sondern deep merge machen
  • spec.clusterConfig.jvmSecurity von Option -> XXX

@razvan
Copy link
Member Author

razvan commented Aug 8, 2023

  • warum nicht in rolegroup cm inkludieren?

Non JVM products would carry a payload in CRDs that is of no use to them.

@sbernauer
Copy link
Member

Non JVM products would carry a payload in CRDs that is of no use to them.

What I meant to say: Every product already has a rolegroup CM. In case a product is JVM based, we can add the config to the already existent CM. In case the product does not need a jvm security config, we don't need to add it to the rolegroup CM. It's the exact same thing as with e.g. a jvm config we already have

@razvan
Copy link
Member Author

razvan commented Aug 24, 2023

Java sec props are implemented as configOverrides in operators. No framework changes needed.

@razvan razvan closed this Aug 24, 2023
@NickLarsenNZ NickLarsenNZ deleted the feat/java-security branch May 6, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants