Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Vector configuration to be compatible with Vector version 0.31.0 #625

Merged
merged 5 commits into from
Aug 1, 2023
Merged

Update the Vector configuration to be compatible with Vector version 0.31.0 #625

merged 5 commits into from
Aug 1, 2023

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Jul 27, 2023 •
edited by maltesander
Loading

Description

Changed

  • BREAKING: Assume that the Vector executable is located in a directory which is specified in the PATH environment variable. This is the case if Vector is installed via RPM.
  • BREAKING: Update product_logging::framework::create_vector_config to be compatible with Vector version 0.31.0. The product image must contain Vector 0.31.x.

Fixed

  • Fix the log level filter for the Vector container. If the level of the ROOT logger was set to TRACE and the level of the file logger was set to DEBUG then TRACE logs were written anyway.

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@siegfriedweber siegfriedweber self-assigned this Jul 27, 2023
@siegfriedweber siegfriedweber mentioned this pull request Jul 27, 2023
Closed
3 tasks
@siegfriedweber
Copy link
Member Author

siegfriedweber commented Jul 28, 2023 •
edited
Loading

successfully tested with stackabletech/airflow-operator#308:
https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/96/

@siegfriedweber siegfriedweber requested a review from a team July 28, 2023 11:56
@siegfriedweber siegfriedweber marked this pull request as ready for review July 28, 2023 11:57
@siegfriedweber siegfriedweber mentioned this pull request Jul 28, 2023
Merged
maltesander
maltesander previously approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@siegfriedweber siegfriedweber added this pull request to the merge queue Aug 1, 2023
Merged via the queue into main with commit e39889c Aug 1, 2023
13 of 14 checks passed
@siegfriedweber siegfriedweber deleted the upgrade-vector branch August 1, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

@maltesander maltesander Awaiting requested review from maltesander

Assignees

@siegfriedweber siegfriedweber

Labels
None yet
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siegfriedweber @maltesander @sbernauer