Skip to content

Commit

Permalink
fix: Fix the CRD description of ClientAuthenticationDetails (#846)
Browse files Browse the repository at this point in the history
* fix: Fix the CRD description of ClientAuthenticationDetails

* changelog

* fix

* fix
  • Loading branch information
sbernauer authored Aug 22, 2024
1 parent c77a542 commit 46d77e1
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 8 deletions.
6 changes: 6 additions & 0 deletions crates/stackable-operator/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.

## [Unreleased]

### Fixed

- Fix the CRD description of `ClientAuthenticationDetails` to not contain internal Rust doc, but a public CRD description ([#846]).

[#846]: https://github.com/stackabletech/operator-rs/pull/846

## [0.74.0] - 2024-08-22

### Added
Expand Down
14 changes: 8 additions & 6 deletions crates/stackable-operator/src/commons/authentication/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -125,15 +125,17 @@ impl AuthenticationClass {
#[serde(rename_all = "camelCase")]
#[schemars(description = "")]
pub struct ClientAuthenticationDetails<O = ()> {
/// A name/key which references an authentication class. To get the concrete
/// [`AuthenticationClass`], we must resolve it. This resolution can be
/// achieved by using [`ClientAuthenticationDetails::resolve_class`].
/// Name of the [AuthenticationClass](https://docs.stackable.tech/home/nightly/concepts/authentication) used to
/// authenticate users.
//
// To get the concrete [`AuthenticationClass`], we must resolve it. This resolution can be achieved by using
// [`ClientAuthenticationDetails::resolve_class`].
#[serde(rename = "authenticationClass")]
authentication_class_ref: String,

/// This field contains authentication provider specific configuration.
///
/// Use [`ClientAuthenticationDetails::oidc_or_error`] to get the value or report an error to the user.
/// This field contains OIDC-specific configuration. It is only required in case OIDC is used.
//
// Use [`ClientAuthenticationDetails::oidc_or_error`] to get the value or report an error to the user.
// TODO: Ideally we want this to be an enum once other `ClientAuthenticationOptions` are added, so
// that user can not configure multiple options at the same time (yes we are aware that this makes a
// changing the type of an AuthenticationClass harder).
Expand Down
4 changes: 2 additions & 2 deletions crates/stackable-operator/src/commons/authentication/oidc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,8 @@ pub struct ClientAuthenticationOptions<T = ()> {
#[serde(default)]
pub extra_scopes: Vec<String>,

/// If desired, operators can add custom fields that are only needed for this specific product.
/// They need to create a struct holding them and pass that as `T`.
// If desired, operators can add custom fields that are only needed for this specific product.
// They need to create a struct holding them and pass that as `T`.
#[serde(flatten)]
pub product_specific_fields: T,
}
Expand Down

0 comments on commit 46d77e1

Please sign in to comment.