Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make uid/gid configurable & change group of files - part 2 #890

Merged
merged 8 commits into from
Oct 16, 2024

Conversation

lfrancke
Copy link
Member

@lfrancke lfrancke commented Oct 8, 2024

Description

Make uid/gid configurable & change group of files.
This is a follow-up for #849 (please check there for details).

This includes ( ✔️ means all tests have been run)

There are still a few tools missing and they'll come in a follow-up PR

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Tasks

TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

This is a follow-up for #849 and includes:

- The missing bits for Hive
- Kafka
- Kafka Testing Tools
- KCat
- NiFi
- Omid
@lfrancke lfrancke marked this pull request as ready for review October 11, 2024 07:39
@lfrancke lfrancke changed the title Make uid/gid configurable & change group of files Make uid/gid configurable & change group of files - part 2 Oct 11, 2024
@lfrancke lfrancke self-assigned this Oct 11, 2024
@NickLarsenNZ NickLarsenNZ self-requested a review October 16, 2024 07:18
NickLarsenNZ
NickLarsenNZ previously approved these changes Oct 16, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I assume the images build locally.

CHANGELOG.md Outdated Show resolved Hide resolved
hive/Dockerfile Outdated Show resolved Hide resolved
opa/Dockerfile Show resolved Hide resolved
@lfrancke
Copy link
Member Author

And to answer your question: Yes, it builds locally and I did run all tests (see the issue description) and it all looks good.

Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lfrancke lfrancke added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 45cbe54 Oct 16, 2024
2 checks passed
@lfrancke lfrancke deleted the feat/user-handling-pt2 branch October 16, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Acceptance: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants