Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Hive image #774

Merged
merged 13 commits into from
Aug 13, 2024
Merged

Rework Hive image #774

merged 13 commits into from
Aug 13, 2024

Conversation

lfrancke
Copy link
Member

@lfrancke lfrancke commented Jul 11, 2024

Description

  • Move postgresql and logging dependencies into build of Hive itself
  • Backport all patches that have been backported on branch-3.1 upstream as well which affect the metastore
  • Update patch dependencies
  • Update Hadoop dependency to 3.3.6

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Tasks

TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

- Move postgresql and logging dependencies into build of Hive itself
- Backport all patches that have been backported on branch-3.1 upstream as well which affect the metastore
- Update patch dependencies
- Update Hadoop dependency to 3.3.6
@lfrancke lfrancke marked this pull request as draft July 11, 2024 16:29
@lfrancke
Copy link
Member Author

I ran all integration tests and they all passed with the exception of the last one (random) which always failed at a Delete namespace step. Need to look into it.

@lfrancke
Copy link
Member Author

The tests succeed after stackabletech/hive-operator#484

@lfrancke lfrancke marked this pull request as ready for review July 15, 2024 15:58
@lfrancke lfrancke self-assigned this Jul 15, 2024
@lfrancke
Copy link
Member Author

We might want to wait with this until after 24.7
I'll let the release team decide.

@NickLarsenNZ
Copy link
Member

Added as a stretch goal to stackabletech/issues#557

@sbernauer sbernauer self-requested a review August 5, 2024 09:30
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not look at the content of the patches. In case I should review them as well pls ping me

hive/upload_new_postgres_driver_version.sh Outdated Show resolved Hide resolved
hive/versions.py Show resolved Hide resolved
hive/stackable/patches/3.1.3/series Outdated Show resolved Hide resolved
hive/Dockerfile Outdated Show resolved Hide resolved
hive/Dockerfile Outdated Show resolved Hide resolved
sbernauer
sbernauer previously approved these changes Aug 12, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not look at the content of the patches. In case I should review them as well pls ping me

@sbernauer
Copy link
Member

Let's wait for #803 first

@sbernauer sbernauer added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit 2e31788 Aug 13, 2024
13 of 14 checks passed
@sbernauer sbernauer deleted the feat/hive-rework branch August 13, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants