Add knip and remove dead code - #329
Open
Bohreromir wants to merge 2 commits into
Open
Bohreromir wants to merge 2 commits into
Bohreromir wants to merge 2 commits into
Conversation
Bohreromir
force-pushed
the
feat/knip
branch
from
September 21, 2026 14:31
2e6413c to
120c777
Compare
Bohreromir
force-pushed
the
feat/knip
branch
from
September 21, 2026 14:37
120c777 to
439c645
Compare
Bohreromir
marked this pull request as ready for review
September 21, 2026 14:37
labrenbe
self-requested a review
September 22, 2026 12:20
labrenbe
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds knip to prevent dead code from accumulating.
It also removes code that is unused in the second commit.