fix: Pass gitsync credentials through properly

[adwk67]

Description

fix/pass gitsync credentials through properly

Jenkins: 🟢 https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/8/
OKD on replicated: 🟢

--- PASS: kuttl (972.27s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/ldap_airflow-latest-2.8.1_ldap-authentication-server-verification-tls_openshift-true_executor-kubernetes (206.21s)
        --- PASS: kuttl/harness/smoke_airflow-2.9.2_openshift-true_executor-kubernetes (270.44s)
        --- PASS: kuttl/harness/resources_airflow-latest-2.8.1_openshift-true (145.02s)
        --- PASS: kuttl/harness/orphaned-resources_airflow-latest-2.8.1_openshift-true (162.93s)
        --- PASS: kuttl/harness/mount-dags-configmap_airflow-latest-2.8.1_openshift-true_executor-kubernetes (145.00s)
        --- PASS: kuttl/harness/cluster-operation_airflow-latest-2.8.1_openshift-true (262.22s)
        --- PASS: kuttl/harness/logging_airflow-2.9.2_openshift-true_executor-kubernetes (479.25s)
        --- PASS: kuttl/harness/mount-dags-gitsync_airflow-latest-2.8.1_openshift-true_executor-kubernetes (205.10s)

Definition of Done Checklist

• Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
• Please make sure all these things are done and tick the boxes

Author

Beta Give feedback

1. Changes are OpenShift compatible
2. Helm chart can be installed and deployed operator works
3. Integration tests passed (for non trivial changes)

Reviewer

Beta Give feedback

1. Code contains useful comments
2. Code contains useful logging statements
3. (Integration-)Test cases added
4. Documentation added or updated. Follows the style guide.
5. Changelog updated
6. Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

Beta Give feedback

1. Feature Tracker has been updated
2. Proper release label has been added
3. Roadmap has been updated

[razvan]

lgtm!

[PaulienVa]

Is this fix available in the nightly build? We are testing it atm and still see the error preventing our statefulsets to start up

[adwk67]

Yes, this is in the nightly build which we use for our integration-testing. Please open an issue if something is not working as expected.

[lfrancke]

Should this be mentioned in the release notes for 24.11? If so, could you please add a snippet?

[adwk67]

@lfrancke sorry for the delay on this. Here, as a comment, or in the changelog?

[adwk67]

Here's a snippet for the release notes:

Fixed in 24.11: in release 24.7 Airflow did not propagate git credentials correctly to the gitsync containers. This has now been corrected and works for both celery- and kubernetes workers.

[lfrancke]

Sorry. Here is fine, thank you!