Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better CRD docs #354

Merged
merged 10 commits into from
Dec 7, 2023
Merged

Better CRD docs #354

merged 10 commits into from
Dec 7, 2023

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Dec 7, 2023 •
edited by adwk67
Loading

Description

Better CRD docs

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Beta Give feedback

Reviewer
Beta Give feedback

Acceptance
Beta Give feedback

@fhennig fhennig marked this pull request as ready for review December 7, 2023 13:18
@fhennig fhennig mentioned this pull request Dec 7, 2023
Closed
adwk67
adwk67 requested changes Dec 7, 2023
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Just a couple of minor changes.

CHANGELOG.md Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
adwk67
adwk67 previously approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fhennig fhennig added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit 0e21b4c Dec 7, 2023
30 checks passed
@fhennig fhennig deleted the feat/better-crd-docs branch December 7, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fhennig @adwk67