Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support PodDisruptionBudgets #330

Merged
merged 10 commits into from
Oct 5, 2023
Merged

feat: Support PodDisruptionBudgets #330

merged 10 commits into from
Oct 5, 2023

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Sep 29, 2023 •
edited by lfrancke
Loading

Description

Part of stackabletech/issues#435

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Beta Give feedback

Reviewer
Beta Give feedback

Acceptance
Beta Give feedback

@sbernauer sbernauer mentioned this pull request Sep 29, 2023
Closed
@sbernauer sbernauer self-assigned this Sep 29, 2023
@adwk67 adwk67 self-requested a review October 5, 2023 11:43
adwk67
adwk67 requested changes Oct 5, 2023
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just minor text stuff.

docs/modules/airflow/pages/usage-guide/operations/graceful-shutdown.adoc Outdated Show resolved Hide resolved
docs/modules/airflow/pages/usage-guide/operations/index.adoc Outdated Show resolved Hide resolved
docs/modules/airflow/pages/usage-guide/operations/pod-disruptions.adoc Outdated Show resolved Hide resolved
docs/modules/airflow/pages/usage-guide/operations/pod-disruptions.adoc Outdated Show resolved Hide resolved
docs/modules/airflow/pages/usage-guide/operations/pod-disruptions.adoc Outdated Show resolved Hide resolved
docs/modules/airflow/pages/usage-guide/operations/pod-disruptions.adoc Outdated Show resolved Hide resolved
@sbernauer sbernauer requested a review from adwk67 October 5, 2023 12:18
@sbernauer
Copy link
Member Author

https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/101/

@sbernauer
Copy link
Member Author

And https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/102/

adwk67
adwk67 previously approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smoke tests run fine locally: lgtm % jenkins tests!

@sbernauer
Copy link
Member Author

Tests passed 🚀

@sbernauer sbernauer requested a review from adwk67 October 5, 2023 13:50
@sbernauer sbernauer added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit 8ee3628 Oct 5, 2023
30 checks passed
@sbernauer sbernauer deleted the feat/support-pdb branch October 5, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adwk67 adwk67 adwk67 approved these changes

Assignees

@sbernauer sbernauer

Labels
release/2023-11
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbernauer @adwk67 @lfrancke