Fixes #61: Added an option to create user on the dashboard's "User" section #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kabir276 is attempting to deploy a commit to the Stack Team on Vercel. A member of the Team first needs to authorize it. |
fomalhautb
reviewed
Jun 11, 2024
|
|
||
| export default function PageClient() { | ||
| const stackAdminApp = useAdminApp(); | ||
| const allUsers = stackAdminApp.useServerUsers(); | ||
| const [addUserOpen, setAddUserOpen] = React.useState(false); | ||
| const [showNotifyPasswordDialog, setShowNotifyPasswordDialog] = React.useState(false); | ||
| const [currentUserPassword, setcurrentUserPassword] = React.useState(""); |
There was a problem hiding this comment.
setcurrent... -> setCurrent...
| onClick: handlePasswordNotificationClose, | ||
| }} | ||
| open={showNotifyPasswordDialog} | ||
| onClose={handlePasswordNotificationClose} |
There was a problem hiding this comment.
eslint not passing: you should use runAsynchronouslyWithAlert, check out the other occurrence. Also please add the eslint plugin to vscode so the errors will be highlighted
| emailVerificationRedirectUrl, | ||
| null, | ||
| ); | ||
| if (!errorCode) { |
There was a problem hiding this comment.
This is a promise, you need to add await
|
Yes, I was getting the same issue but I explicitly commented that “if statement” causing the issue and asked @N2D4 about it. He asked me to make a PR and he’ll take a look at it. |
|
The PR seems to be inactive |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #61
Description
I've added an option to create users on the dashboard's "Users" section. I've created a pull request for your review. Please let me know if this is what you envisioned. If not, I'm happy to make further adjustments.
Changes Made
Updated users>page.client.tsx , lib>stack-app.ts , Interface>clientInterface.ts to include the button to create users.
Additional Notes
No new dependencies were added.