Fix #103 No Open Graph Meta Tags Present #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Riteshyadavanshi is attempting to deploy a commit to the Stack Team on Vercel. A member of the Team first needs to authorize it. |
|
|
|
@Riteshyadavanshi bro, where is that issue, can you please show me, like a screen short etc |
fomalhautb
reviewed
Jul 1, 2024
| @@ -18,11 +18,15 @@ import { RouterProvider } from '@/components/router'; | |||
| import { CSPostHogProvider, UserIdentity } from './providers'; | |||
|
|
|||
| export const metadata: Metadata = { | |||
| metadataBase:new URL("https://stack-auth.com/"), | |||
There was a problem hiding this comment.
The base url should use the DASHBOARD_BASE_URL env var
There was a problem hiding this comment.
also please make sure the formatting is aligned with the other part of the project
| title: { | ||
| default: 'Stack Auth Dashboard', | ||
| template: '%s | Stack Auth', | ||
| }, | ||
| description: 'Stack Auth is the fastest way to add authentication to your web app.', | ||
| openGraph:{ |
|
Hey sir ,I have made the changes just now. you can check it
…On Mon, Jul 1, 2024, 10:24 AM Zai Shi ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In apps/dashboard/src/app/layout.tsx
<#113 (comment)>:
> @@ -18,11 +18,15 @@ import { RouterProvider } from '@/components/router';
import { CSPostHogProvider, UserIdentity } from './providers';
export const metadata: Metadata = {
+ metadataBase:new URL("https://stack-auth.com/"),
The base url should use the DASHBOARD_BASE_URL env var
------------------------------
In apps/dashboard/src/app/layout.tsx
<#113 (comment)>:
> title: {
default: 'Stack Auth Dashboard',
template: '%s | Stack Auth',
},
description: 'Stack Auth is the fastest way to add authentication to your web app.',
+ openGraph:{
same here
------------------------------
In apps/dashboard/src/app/layout.tsx
<#113 (comment)>:
> @@ -18,11 +18,15 @@ import { RouterProvider } from '@/components/router';
import { CSPostHogProvider, UserIdentity } from './providers';
export const metadata: Metadata = {
+ metadataBase:new URL("https://stack-auth.com/"),
also please make sure the formatting is aligned with the other part of the
project
—
Reply to this email directly, view it on GitHub
<#113 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A444J5FVE65EALXJSFZPN3TZKDOJRAVCNFSM6AAAAABKECUQF6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNJQGM4TOMJSGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Please do not open new PRs multiple times. Just update the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.