removed contact channel from user object

stack-auth · Oct 1, 2024 · 3956669 · 3956669
1 parent d556a5e
commit 3956669
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 235 deletions.
diff --git a/apps/backend/src/app/api/v1/users/crud.tsx b/apps/backend/src/app/api/v1/users/crud.tsx
@@ -22,33 +22,14 @@ export const userFullInclude = {
       providerConfig: true,
     },
   },
-  contactChannels: true,
   authMethods: {
     include: {
       passwordAuthMethod: true,
       otpAuthMethod: true,
-      oauthAuthMethod: {
-        include: {
-          oauthProviderConfig: {
-            include: {
-              proxiedOAuthConfig: true,
-              standardOAuthConfig: true,
-            },
-          }
-        }
-      },
-    }
-  },
-  connectedAccounts: {
-    include: {
-      oauthProviderConfig: {
-        include: {
-          proxiedOAuthConfig: true,
-          standardOAuthConfig: true,
-        },
-      }
+      oauthAuthMethod: true,
     }
   },
+  contactChannels: true,
   teamMembers: {
     include: {
       team: true,
@@ -105,8 +86,6 @@ export const userPrismaToCrud = (
     throw new StackAssertionError("User cannot have more than one selected team; this should never happen");
   }
 
-  const contactChannels = prisma.contactChannels.map(c => contactChannelToCrud(c));
-
   // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
   const primaryEmailContactChannel = prisma.contactChannels.find((c) => c.type === 'EMAIL' && c.isPrimary);
   const passwordAuth = prisma.authMethods.find((m) => m.passwordAuthMethod);
@@ -133,7 +112,6 @@ export const userPrismaToCrud = (
     selected_team_id: selectedTeamMembers[0]?.teamId ?? null,
     selected_team: selectedTeamMembers[0] ? teamPrismaToCrud(selectedTeamMembers[0]?.team) : null,
     last_active_at_millis: lastActiveAtMillis,
-    contact_channels: contactChannels,
   };
 };
 

diff --git a/apps/e2e/tests/backend/endpoints/api/v1/auth/password/sign-in.test.ts b/apps/e2e/tests/backend/endpoints/api/v1/auth/password/sign-in.test.ts
@@ -41,6 +41,7 @@ it("should allow signing in to existing accounts", async ({ expect }) => {
     }
   `);
 });
+// TODO: check auth methods
 
 it("should not allow signing in with an e-mail that never signed up", async ({ expect }) => {
   const response = await niceBackendFetch("/api/v1/auth/password/sign-in", {

diff --git a/apps/e2e/tests/backend/endpoints/api/v1/team-memberships.test.ts b/apps/e2e/tests/backend/endpoints/api/v1/team-memberships.test.ts
@@ -71,16 +71,6 @@ it("creates a team and manage users on the server", async ({ expect }) => {
             "auth_with_email": true,
             "client_metadata": null,
             "client_read_only_metadata": null,
-            "contact_channels": [
-              {
-                "id": "<stripped UUID>",
-                "is_primary": true,
-                "is_verified": true,
-                "type": "email",
-                "used_for_auth": true,
-                "value": "<stripped UUID>@stack-generated.example.com",
-              },
-            ],
             "display_name": null,
             "has_password": false,
             "id": "<stripped UUID>",
@@ -99,16 +89,6 @@ it("creates a team and manage users on the server", async ({ expect }) => {
             "auth_with_email": true,
             "client_metadata": null,
             "client_read_only_metadata": null,
-            "contact_channels": [
-              {
-                "id": "<stripped UUID>",
-                "is_primary": true,
-                "is_verified": true,
-                "type": "email",
-                "used_for_auth": true,
-                "value": "<stripped UUID>@stack-generated.example.com",
-              },
-            ],
             "display_name": null,
             "has_password": false,
             "id": "<stripped UUID>",
@@ -157,16 +137,6 @@ it("creates a team and manage users on the server", async ({ expect }) => {
             "auth_with_email": true,
             "client_metadata": null,
             "client_read_only_metadata": null,
-            "contact_channels": [
-              {
-                "id": "<stripped UUID>",
-                "is_primary": true,
-                "is_verified": true,
-                "type": "email",
-                "used_for_auth": true,
-                "value": "<stripped UUID>@stack-generated.example.com",
-              },
-            ],
             "display_name": null,
             "has_password": false,
             "id": "<stripped UUID>",