Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3.0.0 #198

Merged
merged 11 commits into from
Mar 14, 2022
Merged

V3.0.0 #198

merged 11 commits into from
Mar 14, 2022

Conversation

jonhealy1
Copy link
Collaborator

No description provided.

@jonhealy1 jonhealy1 requested review from gadomski and jbants March 11, 2022 17:52
@jonhealy1
Copy link
Collaborator Author

jonhealy1 commented Mar 11, 2022

@gadomski @jbants There is this test below Execute tests (3.6) Expected — Waiting for status to be reported that never seems to finish and I don't know how to remove it - it's really annoying. Is it some sort of an artifact?

Copy link
Collaborator

@jbants jbants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks Jon.

@jbants
Copy link
Collaborator

jbants commented Mar 11, 2022

@gadomski @jbants There is this test below Execute tests (3.6) Expected — Waiting for status to be reported that never seems to finish and I don't know how to remove it - it's really annoying. Is it some sort of an artifact?

I think this is because it still references the .tox file in master. Merging this should fix the test.
This Pr should close #189

@gadomski
Copy link
Member

@gadomski @jbants There is this test below Execute tests (3.6) Expected — Waiting for status to be reported that never seems to finish and I don't know how to remove it - it's really annoying. Is it some sort of an artifact?

It was a leftover check for a python 3.6 CI run that got removed. I removed the check from the branch protection and things look good now.

@jonhealy1
Copy link
Collaborator Author

@gadomski @jbants There is this test below Execute tests (3.6) Expected — Waiting for status to be reported that never seems to finish and I don't know how to remove it - it's really annoying. Is it some sort of an artifact?

It was a leftover check for a python 3.6 CI run that got removed. I removed the check from the branch protection and things look good now.

Nice thank you!!!

@jonhealy1
Copy link
Collaborator Author

#196 I don't know if this works until this pr is merged ...

CHANGELOG.md Show resolved Hide resolved
@jonhealy1 jonhealy1 requested a review from gadomski March 11, 2022 22:01
@jonhealy1 jonhealy1 merged commit 2ff152a into main Mar 14, 2022
@gadomski gadomski deleted the v3.0.0 branch March 14, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants